Skip to content

Merge to main: SCHED-921: Pass tf vars in json#2153

Merged
theyoprst merged 2 commits intomainfrom
merge-to-main-from/pr-2151/SCHED-921/escape-vars
Feb 10, 2026
Merged

Merge to main: SCHED-921: Pass tf vars in json#2153
theyoprst merged 2 commits intomainfrom
merge-to-main-from/pr-2151/SCHED-921/escape-vars

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This is merge back of the Pull Request #2151 by @theyoprst

Original PR Description

Problem

Some tf var now contain quotes:

nvidia_admin_conf_lines = [
  "options nvidia NVreg_RestrictProfilingToAdminUsers=0", # Allow access to GPU counters in nsys profiler for non-root users
  "options nvidia NVreg_EnableStreamMemOPs=1",
+  "options nvidia NVreg_RegistryDwords=\"PeerMappingOverride=1;\"",
]

Because of that, terratest runs terraform with wrongly formatted vars:
-var nvidia_admin_conf_lines=["options nvidia NVreg_RestrictProfilingToAdminUsers=0", "options nvidia NVreg_EnableStreamMemOPs=1", "options nvidia NVreg_RegistryDwords="PeerMappingOverride=1;""]

And it leads to terraform errors:

TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: Error: Missing item separator
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: 
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67:   on <value for var.nvidia_admin_conf_lines> line 1:
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67:   (source code not available)
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: 
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: Expected a comma to mark the beginning of the next item.

Solution

Pass vars as a JSON, which already does proper escaping.

Testing

https://github.com/nebius/soperator/actions/runs/21860154458/job/63086857937
(cancelled after successful passed the problematic point)

theyoprst and others added 2 commits February 10, 2026 10:31
…sues in e2e tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the ignore-for-release Don't include this PR into changelog label Feb 10, 2026
@theyoprst theyoprst merged commit e75fac0 into main Feb 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Don't include this PR into changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant