Merge to main: SCHED-921: Pass tf vars in json#2153
Merged
Conversation
…sues in e2e tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SCHED-921: Pass tf vars in json
theyoprst
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is merge back of the Pull Request #2151 by @theyoprst
Original PR Description
Problem
Some tf var now contain quotes:
nvidia_admin_conf_lines = [ "options nvidia NVreg_RestrictProfilingToAdminUsers=0", # Allow access to GPU counters in nsys profiler for non-root users "options nvidia NVreg_EnableStreamMemOPs=1", + "options nvidia NVreg_RegistryDwords=\"PeerMappingOverride=1;\"", ]Because of that, terratest runs terraform with wrongly formatted vars:
-var nvidia_admin_conf_lines=["options nvidia NVreg_RestrictProfilingToAdminUsers=0", "options nvidia NVreg_EnableStreamMemOPs=1", "options nvidia NVreg_RegistryDwords="PeerMappingOverride=1;""]And it leads to terraform errors:
Solution
Pass vars as a JSON, which already does proper escaping.
Testing
https://github.com/nebius/soperator/actions/runs/21860154458/job/63086857937
(cancelled after successful passed the problematic point)