Validate enabled built-in Slurm scripts#2779
Merged
Merged
Conversation
theyoprst
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slurmScripts.builtInentry has bundled script content whencustomContentis not providedcustomConfigis not providedWhy
Helm values can retain an enabled built-in entry after that check has been removed from a newer chart version. The template previously accepted the unknown key, rendered an empty script, and attempted to parse an empty check specification. The resulting malformed
checks.jsoncould causecheck_runner.pyto reject the complete configuration and run no health checks.This issue was identified while preparing #2778. It is implemented separately from
mainso #2778 can remain focused on removing the obsoletealloc_mem_usedcheck.Impact
Upgrades with stale or misspelled enabled built-in keys now fail during Helm rendering with instructions to remove the obsolete entry or provide the corresponding custom content/configuration.
Valid bundled checks and built-ins with explicit
customContentorcustomConfigcontinue to render unchanged.Validation
helm unittest -f 'tests/slurm_scripts_test.yaml' helm/slurm-cluster— 2 tests passedhelm unittest helm/slurm-cluster— 101 tests passed across 18 suiteshelm templaterendering passedgit diff --checkpassed