chore(test): fix no-unused-vars lint errors in types.test.ts#699
Merged
Conversation
The compile-time type tests declare consts solely to trip their @ts-expect-error directives, so they are never read. Prefix them with `_` (the escape hatch the no-unused-vars rule is configured to allow) and apply Prettier formatting. Side effect: reference the shared .claude/shared-rules.md from CLAUDE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
need4deed
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typescript-eslint/no-unused-varserrors insrc/test/server/utils/types.test.ts— the only lint errors in the test suite.constexists only to trip its@ts-expect-errordirective, so it's never read. Renamed with the_prefix that theno-unused-varsrule is configured to allow (Allowed unused vars must match /^_/u). The@ts-expect-errorassertions still fire, so the tests remain meaningful.CLAUDE.mdnow references the tracked.claude/shared-rules.md.Verification
npx eslint 'src/test/**/*.ts'→ 0 errorsyarn typecheck→ clean (@ts-expect-errordirectives still valid)🤖 Generated with Claude Code