add four new appreciation options to the dialog - #910
Open
ivannissimrch wants to merge 1 commit into
Open
Conversation
4 tasks
Collaborator
Author
|
Note on order: this needs BE 845 to merge first. Until then, the four new options appear in the dialog, but saving one returns a 400, since the request validation schema still lists only the original three values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the four new options to the Add Appreciation dialog: Need4Deed certificate, cap, notebook and city certificate. Previously, only tote bag, t-shirt, and benefit card were offered.
Blocked on the backend.
Saving one of the new options currently returns a 400.
sdk-types.jsonin the backend still lists only the old three values, so the request is rejected during validation. Issue: 837. Everything else is in place; the database migration and the SDK both have all seven.Related Issues
Closes #872
Changes
APPRECIATION_TYPESinAppreciationDialog.tsxcityCertificatecorrected to SenatsurkundeScreenshots / Demos
Checklist