fix: improve code-review-fix skill to prevent auto-close failures - #119
Merged
Conversation
- Add critical guidance on Fixes #N keyword placement in PR bodies - GitHub only recognizes standalone Fixes #N lines, not embedded in prose - Add post-merge verification step to catch failed auto-closes - Add orphaned issues section with procedure to find and close them - Update PR body template to include Fixes #N on its own line - Document known failure patterns (comma-separated, 'and' lists)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The code-review-fix skill's PR template used in commit messages and checkbox sections in PR bodies. GitHub's auto-close only reliably works when appears as a standalone keyword line in the PR body. This caused issue #69 to stay open after PR #103 was merged (the body said
Fixes #67 and #69— GitHub only recognized the first).Changes
Fixeskeyword patterns work vs silently failFixes #<number>on its own lineClosing Orphaned Issuessection with procedure to find and close missed issuesFixes #NlinesFixes #115