Feat/no minlength for known tracks#13
Merged
Merged
Conversation
added 6 commits
July 16, 2026 22:20
…ection; fix quoting
…p from job.Tracks
When the app already knows the exact track to rip (TestMode or MainFeature modes), --minlength is counterproductive — it causes MakeMKV to filter out the requested title if it's shorter than the threshold, resulting in exit code 12 and zero output. The info scan already handles min-length filtering. Also reverted unnecessary SourceTitleId parameter on RipTrackAsync — the sequential TINFO index (TrackNumber) is the correct argument for the mkv command, not the DVD VTS source title ID (field 24).
- Removed AddSourceTitleId migration (DB column not needed) - Removed SourceTitleId property from Track, DiscTrack models - Removed SourceTitleId enum value from MakeMkvModels - Removed SourceTitleId parsing from MakeMkvService (field 24 is the DVD VTS title ID, not what makemkvcon mkv expects — it uses sequential index) - Reverted NotificationHub.cs and Viewer.cshtml changes (log streaming improvements unrelated to this branch)
- Re-add SourceTitleId (TINFO field 24) to fix MakeMKV mkv command title selection: the 0-based TINFO index was causing '0' to be passed to MakeMKV's mkv command, which MakeMKV interprets as 'rip all titles' instead of 'rip title 1'. Now we pass the actual 1-based title number. - 0-track fallback: retry info scan with normal minLength before falling back to RipAllTitles, so a DiscDb-enabled exhaustive scan timeout doesn't bypass MainFeature track selection. - Add MarkStageComplete(Rip) to the 0-track fallback path. - Add yellow 'Small file' warning on completed movie files under 2GB on both the Output list and detail pages.
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceTitleId fix — MakeMKV's mkv command interprets 0 as "rip all titles", so the 0-based TINFO index was wrong. Now uses TINFO field 24 (actual 1-based title number).
0-track fallback retry — Retries info scan with normal minLength before giving up and ripping all titles, so DiscDb exhaustive scan timeouts don't bypass MainFeature selection.
MarkStageComplete(Rip) — was missing from the fallback path.