Skip to content

fix: switch Job Details UI out of manual selection immediately after submit (closes #182) - #183

Merged
negativeeddy merged 1 commit into
masterfrom
fix/issue-#182
Sep 5, 2026
Merged

fix: switch Job Details UI out of manual selection immediately after submit (closes #182)#183
negativeeddy merged 1 commit into
masterfrom
fix/issue-#182

Conversation

@negativeeddy

Copy link
Copy Markdown
Owner

Automated Fix

Fixes #182

Changes

The Job Details page kept showing the "▶ Continue Rip" button (and the track checkbox column) after a manual track selection was submitted, until a manual page refresh. Root cause: submitManualSelection() called location.reload() immediately after the API returned success, but the pipeline needs several DB round-trips before the job status actually leaves manual_selection — so the reload re-rendered the button. The SignalR live-update path also never removed the checkbox column.

  • submitManualSelection() now optimistically removes the manual-selection UI (Continue button + track checkboxes) the moment the API confirms success, then polls GET /api/jobs/{id} until the job leaves manual_selection before reloading (with a ~10s fallback so the page can never get stuck).
  • updateActionButtons() now strips the manual-selection UI whenever the status changes away from manual_selection (covers the SignalR path, e.g. timeout → failure), and won't re-add the Continue button if a stale broadcast arrives after the user already submitted.
  • Added a regression test asserting the manual-selection page renders the new helpers.

Testing

  • All existing tests pass
  • New test: JobDetail_ManualSelectionState_RendersSelectionUiAndSubmitHelpers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job Details page: manual mode continnue button doesnt go away

1 participant