Replace gopass lib with golang.org/x/term#674
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 49.27% 50.00% +0.72%
==========================================
Files 23 23
Lines 2401 2518 +117
==========================================
+ Hits 1183 1259 +76
- Misses 1090 1124 +34
- Partials 128 135 +7
Continue to review full report at Codecov.
|
cplee
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: replace
gopasslib withgolang.org/x/termAdditionally replaced
FatalfwithErrorfsince it's bad to exit a program this way (likePanic)Ongoing effort to remove old and abandoned libraries