Skip to content

Replace gopass lib with golang.org/x/term#674

Merged
mergify[bot] merged 2 commits into
nektos:masterfrom
catthehacker:cat/fix/replace-gopass
May 6, 2021
Merged

Replace gopass lib with golang.org/x/term#674
mergify[bot] merged 2 commits into
nektos:masterfrom
catthehacker:cat/fix/replace-gopass

Conversation

@catthehacker

Copy link
Copy Markdown
Member

fix: replace gopass lib with golang.org/x/term
Additionally replaced Fatalf with Errorf since it's bad to exit a program this way (like Panic)

Ongoing effort to remove old and abandoned libraries

@catthehacker catthehacker requested a review from a team as a code owner May 6, 2021 17:08
@codecov

codecov Bot commented May 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #674 (3ce1e36) into master (0f04942) will increase coverage by 0.72%.
The diff coverage is 61.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   49.27%   50.00%   +0.72%     
==========================================
  Files          23       23              
  Lines        2401     2518     +117     
==========================================
+ Hits         1183     1259      +76     
- Misses       1090     1124      +34     
- Partials      128      135       +7     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.82% <0.00%> (-0.11%) ⬇️
pkg/common/git.go 55.88% <5.00%> (-3.92%) ⬇️
pkg/model/workflow.go 30.71% <33.33%> (+5.00%) ⬆️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 71.71% <72.64%> (+2.76%) ⬆️
pkg/runner/run_context.go 77.54% <94.54%> (+1.14%) ⬆️
pkg/runner/runner.go 76.92% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a144e71...3ce1e36. Read the comment docs.

@mergify mergify Bot merged commit a6a865e into nektos:master May 6, 2021
@catthehacker catthehacker deleted the cat/fix/replace-gopass branch May 20, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants