Correct the upload gate's comment about backend enforcement - #235
Merged
Conversation
Deploying nemar-website with
|
| Latest commit: |
d6aef8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7345dc51.nemar-website.pages.dev |
| Branch Preview URL: | https://fix-upload-gate-comment.nemar-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment added in #231 claimed "The backend enforces its own gate regardless
(nemar-cli#1013 Phase 1), this stops the wasted trip." That is wrong, and it is
the kind of wrong that makes a future reader delete the gate believing the
backend still covers it.
backend/src/services/upload-gate.tson nemar-climaingates real uploads onservice_accessandsandbox_completed. It does not look at city or country atall. Those two fields are the inputs an admin reviews before granting service
access (ADR 0010), not something any endpoint rejects an upload for.
So this frontend check is the only place the city/country requirement is
enforced, not a courtesy layer over a server-side one. The comment now says so
explicitly, including what breaks if someone softens it.
Comment only; no behavior change. Found by a release reviewer on the v0.2.4
promotion diff.