Annotation: Return saves after mouse tag picks - #266
Merged
neuromechanist merged 1 commit intoSep 1, 2026
Merged
Conversation
A mouse click on a quick-pick chip or search result left focus on that button, where Enter re-activates the button (ENTER_OWNING_TAGS defers to it for keyboard users) instead of saving - so the natural mouse flow drag -> click tag -> Return never saved. Mouse activations (detail > 0) now hand focus back to the search input; keyboard activations (detail 0) keep focus on the chip. Tested: typecheck, lint, 1347 vitest; reported by Yahya in live QA.
Deploying nemar-website with
|
| Latest commit: |
a7b5b64
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e50dd05.nemar-website.pages.dev |
| Branch Preview URL: | https://fix-annotation-enter-focus.nemar-website.pages.dev |
neuromechanist
merged commit Sep 1, 2026
0be63fa
into
feature/issue-256-epic-viewer-workbench
5 checks passed
This was referenced Sep 1, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-QA follow-up to #263 (part of epic #256). A mouse click on a quick-pick chip or a search result left focus on that button, where Enter re-activates the button rather than saving (the ENTER_OWNING_TAGS deferral exists for keyboard users). The natural mouse flow drag -> click tag -> Return therefore never saved, as Yahya found testing live. Mouse activations (event.detail > 0) now return focus to the search input so Return means save; keyboard activations (detail 0) are untouched, keeping the vocabulary keyboard-reachable.
Gates: typecheck 0 errors, lint clean, 1347 tests, verified by Yahya on the live dev server.