Skip to content

Annotation: whole-schema vocabulary search - #269

Merged
neuromechanist merged 1 commit into
feature/issue-256-epic-viewer-workbenchfrom
fix/full-vocab-search
Sep 1, 2026
Merged

Annotation: whole-schema vocabulary search#269
neuromechanist merged 1 commit into
feature/issue-256-epic-viewer-workbenchfrom
fix/full-vocab-search

Conversation

@neuromechanist

Copy link
Copy Markdown
Contributor

Live-QA round 5 from Yahya (part of epic #256):

  1. The search reached only the curated 488-tag subset, so "Building", "Left", "Right" returned nothing and "sleep" missed tags outside the curated subtrees. The bundle now carries every non-deprecated tag of BOTH schemas — 1,525 tags (1,129 base HED 8.4.0 + 396 SCORE 2.1.0) at 341 KB raw / 68 KB gzipped, still loaded lazily with the popover, never with the viewer. Curation now decides only the quick-pick chips (what is offered before typing), not what search can find.
  2. While a query is active the quick-pick groups hide, so results are the only list on screen; clearing the search restores them.

New tests pin whole-schema coverage (Building/Left-side-of/Right-side-of present; a "sleep" query returns every sleep-carrying tag across both schemas) and the deprecated-tag exclusion; the bundle size cap rises to 500 KB with the rationale recorded.

Gates: typecheck 0 errors, lint clean, build clean, 1353 tests.

Yahya's QA round 5: the search box only reached a curated 488-tag
subset, so Building/Left/Right found nothing and 'sleep' missed tags.
The bundle now carries every non-deprecated tag of both schemas
(1525 tags: 1129 base HED + 396 SCORE; 341 KB raw, 68 KB gzipped,
still popover-lazy). Curation now lives only in the quick-picks.
Active searches hide the quick-pick groups so results are the only
list on screen; clearing the box restores them.

Tested: typecheck, lint, build, 1353 vitest (new whole-schema
coverage cases; size cap raised to 500 KB with rationale).
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploying nemar-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: a49e7a4
Status: ✅  Deploy successful!
Preview URL: https://4b10af66.nemar-website.pages.dev
Branch Preview URL: https://fix-full-vocab-search.nemar-website.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant