Annotation: whole-schema vocabulary search - #269
Merged
neuromechanist merged 1 commit intoSep 1, 2026
Merged
Conversation
Yahya's QA round 5: the search box only reached a curated 488-tag subset, so Building/Left/Right found nothing and 'sleep' missed tags. The bundle now carries every non-deprecated tag of both schemas (1525 tags: 1129 base HED + 396 SCORE; 341 KB raw, 68 KB gzipped, still popover-lazy). Curation now lives only in the quick-picks. Active searches hide the quick-pick groups so results are the only list on screen; clearing the box restores them. Tested: typecheck, lint, build, 1353 vitest (new whole-schema coverage cases; size cap raised to 500 KB with rationale).
Deploying nemar-website with
|
| Latest commit: |
a49e7a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4b10af66.nemar-website.pages.dev |
| Branch Preview URL: | https://fix-full-vocab-search.nemar-website.pages.dev |
neuromechanist
merged commit Sep 1, 2026
09dd2b5
into
feature/issue-256-epic-viewer-workbench
5 checks passed
This was referenced Sep 1, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-QA round 5 from Yahya (part of epic #256):
New tests pin whole-schema coverage (Building/Left-side-of/Right-side-of present; a "sleep" query returns every sleep-carrying tag across both schemas) and the deprecated-tag exclusion; the bundle size cap rises to 500 KB with the rationale recorded.
Gates: typecheck 0 errors, lint clean, build clean, 1353 tests.