Pair drift check to nemar-cli dev - #315
Merged
Merged
Conversation
Deploying nemar-website with
|
| Latest commit: |
e5441b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d19fb7d.nemar-website.pages.dev |
| Branch Preview URL: | https://fix-parity-ref-pairing.nemar-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of nemarOrg/nemar-cli#1278. See nemarOrg/nemar-cli#1277 for the full write-up and nemar-cli ADR 0046 for the decision.
The drift check pinned nemar-cli's
mainwhenever the PR targetsmain. nemar-cli's parity test had the mirror-image rule, so a coordinated release deadlocks: #314 waits on nemar-cli's unpromotedmainwhile nemar-cli#1276 waits on ours. Both went red today and neither could merge to unblock the other.The checkout now always uses nemar-cli
dev.staginganddevare the coupled pair;mainon either side is only a snapshot of them, so amainvsmaincomparison asserts nothing once both have promoted.This is not a first-release bootstrap problem. On a later release the contract exists on nemar-cli
mainbut carries the previous release's strings, so the same comparison fails on content instead of absence, which reads as real drift.Verification
bunx vitest run test/account-copy-drift.test.tswithNEMAR_CLI_ACCOUNT_COPYpointed at nemar-clidev: 10 tests, all pass, no skips.