Better schema check #495
Merged
Better schema check #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Any comments? |
Contributor
|
Yes :), I didn't know that that the |
leobeal
reviewed
Sep 1, 2025
leobeal
reviewed
Sep 1, 2025
Contributor
Author
|
Thanks for the review: It made sense to me a few hours ago... 🫤 but yes testing the key is wrong and it only worked in my tests because my two mistakes canceled each other out. I will resubmit this PR tomorrow. |
Contributor
Author
|
Should be good now. |
Contributor
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for
pain.001.001.09for transfers, and also ignores the GBIC_X postfix in the xml namespaces the bank reports supporting.refs #493