perf: optimize unread notification count query#210
Open
Ayush-0918 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
🎉 Thank you for your first Pull Request to DevLink!
We appreciate your contribution to our open-source community.
Before your PR is reviewed, please ensure:
- ✅ The project builds successfully.
- ✅ Your code follows the project's coding standards.
- ✅ You have tested your changes.
- ✅ Related documentation has been updated if necessary.
Our maintainers will review your PR as soon as possible.
Thank you for helping improve DevLink! 💙
Owner
|
attached videos and screenshots showing what changes have been made also some CI jobs are failing update it. |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Optimized the unread notification count by replacing the previous implementation, which loaded unread notifications into memory, with a SQL
COUNT(*)query for better performance.Related Issue
Closes #199
Type of Change
Changes Made
SELECT COUNT(*).func.count()instead of loading all unread notification objects.Screenshots (if applicable)
N/A
Testing
Additional testing notes:
COUNT(*).Checklist
Additional Notes
This change only optimizes the unread notification count query. No functional behavior has been modified.