sync to Neo.SmartContract.Framework v3.0.0-rc3 by superboyiii · Pull Request #44 · neo-project/examples

superboyiii · 2021-04-15T08:08:31Z

Close #46

superboyiii · 2021-04-15T08:08:59Z

erikzhang · 2021-04-15T08:20:14Z

Duplicate of #43

chenzhitong · 2021-04-15T10:50:22Z

csharp/NEP17/NEP17.cs

+
+        public static UInt160 GetOwner() => Owner;
+
+        public static UInt160 GetOwner2() => Owner2;


For testing?

chenzhitong · 2021-04-15T10:52:57Z

csharp/NEP17/NEP17.cs

    [ManifestExtra("Description", "This is a NEP17 example")]
    [SupportedStandards("NEP-17")]
-    [ContractPermission("*", "onNEP17Payment")]
+    [ContractPermission("*", "*")]


Why change this line

chenzhitong · 2021-04-16T06:28:52Z

csharp/NEP17/NEP17.csproj


  <ItemGroup>
-    <PackageReference Include="Neo.SmartContract.Framework" Version="3.0.0-preview5" />
+    <PackageReference Include="Neo.SmartContract.Framework" Version="3.0.0-CI00300" />


Missing NuGet.Config file

<?xml version="1.0" encoding="utf-8"?> <configuration> <packageSources> <clear /> <add key="MyGet-neo" value="https://www.myget.org/F/neo/api/v3/index.json" /> <add key="NuGet.org" value="https://api.nuget.org/v3/index.json" /> </packageSources> </configuration>

superboyiii · 2021-04-16T07:11:28Z

Duplicate of #43

We can iterate examples if any code style changes but not do anything together before release, it could help developers to know the changes step by step.

satoshichou · 2021-04-16T09:46:20Z

Duplicate of #43

We can iterate examples if any code style changes but not do anything together before release, it could help developers to know the changes step by step.

Agree, it's good for me. I'm writing sc on neo and it makes the example more clear and these methods are all compatible with the latest compiler as what I tested.

erikzhang · 2021-04-17T08:08:20Z

The NEP-17 example should inherit Nep17Token.

Please update to 3.0.0-rc2

For RC2

update csproj

superboyiii · 2021-05-14T03:18:29Z

The NEP-17 example should inherit Nep17Token.
Please update to 3.0.0-rc2

All done.

nicolegys

tested

csharp/NEP17/NEP17.cs

csharp/NEP17/NuGet.Config

superboyiii · 2021-06-23T03:50:19Z

@erikzhang pls review again.

shargon

Tested?

csharp/NEP17/NEP17.cs

nicolegys

Test pass

superboyiii · 2021-06-23T10:39:48Z

@shargon pls review again.

superboyiii · 2021-06-25T02:25:18Z

@erikzhang Merge?

vncoelho

Working as expected. Thanks,

sync to Neo.SmartContract.Framework v3.0.0-CI00300

4deae47

erikzhang marked this as a duplicate of #43 Apr 15, 2021

chenzhitong reviewed Apr 15, 2021

View reviewed changes

chenzhitong reviewed Apr 16, 2021

View reviewed changes

superboyiii added 2 commits April 16, 2021 14:42

fix

7402940

Add safe label and IsPayable()

2e2f46e

add NuGet.Config

116e223

chenzhitong previously approved these changes Apr 16, 2021

View reviewed changes

shargon previously approved these changes Apr 16, 2021

View reviewed changes

superboyiii and others added 2 commits May 14, 2021 11:10

For RC2

05a0cd4

Merge pull request #1 from superboyiii/rc2

10b1d17

For RC2

superboyiii dismissed chenzhitong’s stale review via 10b1d17 May 14, 2021 03:14

superboyiii changed the title ~~sync to Neo.SmartContract.Framework v3.0.0-CI00300~~ sync to Neo.SmartContract.Framework v3.0.0-rc2 May 14, 2021

superboyiii and others added 2 commits May 14, 2021 11:16

update csproj

1edc6f2

Merge pull request #2 from superboyiii/rc2

517e0eb

update csproj

nicolegys previously approved these changes May 14, 2021

View reviewed changes

erikzhang reviewed May 14, 2021

View reviewed changes

csharp/NEP17/NEP17.cs Show resolved Hide resolved

erikzhang reviewed May 14, 2021

View reviewed changes

csharp/NEP17/NuGet.Config Outdated Show resolved Hide resolved

improve

4bd75f8

superboyiii dismissed nicolegys’s stale review via 4bd75f8 June 23, 2021 03:49

shargon reviewed Jun 23, 2021

View reviewed changes

csharp/NEP17/NEP17.cs Outdated Show resolved Hide resolved

csharp/NEP17/NEP17.cs Show resolved Hide resolved

superboyiii added 2 commits June 23, 2021 16:28

format

50b98e8

fix

a777968

superboyiii changed the title ~~sync to Neo.SmartContract.Framework v3.0.0-rc2~~ sync to Neo.SmartContract.Framework v3.0.0-rc3 Jun 23, 2021

superboyiii added 2 commits June 23, 2021 18:08

fix

7f68c6d

set data to null

fc9361f

nicolegys previously approved these changes Jun 23, 2021

View reviewed changes

shargon previously approved these changes Jun 24, 2021

View reviewed changes

Change Prefix_Contract to byte

7005756

superboyiii dismissed stale reviews from shargon and nicolegys via 7005756 June 29, 2021 06:16

erikzhang approved these changes Jun 29, 2021

View reviewed changes

shargon approved these changes Jun 29, 2021

View reviewed changes

vncoelho approved these changes Jun 29, 2021

View reviewed changes

vncoelho merged commit 0b2ff45 into neo-project:master Jun 29, 2021


		public static UInt160 GetOwner() => Owner;

		public static UInt160 GetOwner2() => Owner2;

Conversation

superboyiii commented Apr 15, 2021 • edited by erikzhang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

superboyiii commented Apr 15, 2021

Uh oh!

erikzhang commented Apr 15, 2021

Uh oh!

chenzhitong Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

chenzhitong Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

chenzhitong Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

superboyiii commented Apr 16, 2021

Uh oh!

satoshichou commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikzhang commented Apr 17, 2021

Uh oh!

superboyiii commented May 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolegys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

superboyiii commented Jun 23, 2021

Uh oh!

shargon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicolegys left a comment

Choose a reason for hiding this comment

Uh oh!

superboyiii commented Jun 23, 2021

Uh oh!

superboyiii commented Jun 25, 2021

Uh oh!

vncoelho left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

superboyiii commented Apr 15, 2021 •

edited by erikzhang

Loading

chenzhitong Apr 16, 2021 •

edited

Loading

satoshichou commented Apr 16, 2021 •

edited

Loading

superboyiii commented May 14, 2021 •

edited

Loading