Stash new transactions during persist#1606
Closed
Qiao-Jin wants to merge 13 commits intoneo-project:masterfrom
Closed
Stash new transactions during persist#1606Qiao-Jin wants to merge 13 commits intoneo-project:masterfrom
Qiao-Jin wants to merge 13 commits intoneo-project:masterfrom
Conversation
shargon
reviewed
Apr 23, 2020
shargon
reviewed
Apr 23, 2020
| OnPongMessageReceived((PingPayload)msg.Payload); | ||
| break; | ||
| case MessageCommand.Transaction: | ||
| while (Blockchain.Singleton.isPersisting) |
Member
There was a problem hiding this comment.
This could backfire, if you wait for the incoming tx it could decrease the TPS
Contributor
Author
There was a problem hiding this comment.
By experiments such modification does enhance TPS though..
I think things might be like this: The amount of verified transactions during persisting is very limited, as persisting also takes a lot of CPU resource. And on the other hand persisting is so long that overall TPS is lowerd.
Contributor
Author
There was a problem hiding this comment.
Hi Shargon, I changed the strategy to making remotenode stashing transactions while blockchain persisting block, please have a check:)
Qiao-Jin
changed the title
Tommo-L
reviewed
Apr 27, 2020
Contributor
Author
|
Close due to having found better method to restrict remote node verification during persisting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1605
This PR needs PR #1507 as precondition.