Adds some missing migration steps, and fixes a typo #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
lidiazuin
reviewed
Aug 31, 2023
Contributor
lidiazuin
left a comment
lidiazuin
left a comment
There was a problem hiding this comment.
I've seen you merged the PR while I was reviewing, so I'll just leave these comments to catch up on a new PR for an editorial review :)
|
|
||
| Additionally, escaping strings is no longer needed. | ||
|
|
||
| === `@exclude` removed |
Contributor
There was a problem hiding this comment.
Can't we use the label deprecated for it?
Suggested change
| === `@exclude` removed | |
| === `@exclude` label:[deprecated] |
|
|
||
| === `@exclude` removed | ||
|
|
||
| The `@exclude` directive has been removed in favor of much more granular configuration directives. |
Contributor
There was a problem hiding this comment.
Suggested change
| The `@exclude` directive has been removed in favor of much more granular configuration directives. | |
| The `@exclude` directive has been removed in favor of a more granular configuration directives. |
| === `@exclude` removed | ||
|
|
||
| The `@exclude` directive has been removed in favor of much more granular configuration directives. | ||
|
|
|
|
||
| The `@exclude` directive has been removed in favor of much more granular configuration directives. | ||
|
|
||
| The new `@query`, `@mutation` and `@subscription` directives instead allow for fully granular configuration for each operation. |
Contributor
There was a problem hiding this comment.
Suggested change
| The new `@query`, `@mutation` and `@subscription` directives instead allow for fully granular configuration for each operation. | |
| The `@query`, `@mutation` and `@subscription` directives instead allow for fully granular configuration for each operation. |
| * `@exclude(operations: [READ])` and `@query(read: false, aggregate: false)`. | ||
| * `@exclude(operation: [CREATE, UPDATE, DELETE])` and `@mutation(operations: [])`. | ||
|
|
||
| Whilst there is more verbosity, the directives are significantly more powerful and extensible as the library gains features. |
Contributor
There was a problem hiding this comment.
Suggested change
| Whilst there is more verbosity, the directives are significantly more powerful and extensible as the library gains features. | |
| Despite the verbosity, the directives are significantly more powerful and extensible as the library gains features. |
| === `@readonly` and `@writeonly` removed | ||
|
|
||
| The `@readonly` and `@writeonly` directives have been removed in favor of more granular configuration directives. | ||
| The new `@selectable` and `@settable` directives can be used to configure not only if fields are readable or writable, but also when they should be readable or writable. |
Contributor
There was a problem hiding this comment.
Suggested change
| The new `@selectable` and `@settable` directives can be used to configure not only if fields are readable or writable, but also when they should be readable or writable. | |
| The `@selectable` and `@settable` directives can be used to configure not only if fields are readable or writable, but also when they should be readable or writable. |
| } | ||
| ---- | ||
|
|
||
| === `@readonly` and `@writeonly` removed |
Contributor
There was a problem hiding this comment.
Same here about the label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.