-
Notifications
You must be signed in to change notification settings - Fork 15
Adds some missing migration steps, and fixes a typo #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -572,6 +572,20 @@ type query { | |||||
|
|
||||||
| Additionally, escaping strings is no longer needed. | ||||||
|
|
||||||
| === `@exclude` removed | ||||||
|
|
||||||
| The `@exclude` directive has been removed in favor of much more granular configuration directives. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| The new `@query`, `@mutation` and `@subscription` directives instead allow for fully granular configuration for each operation. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| As a direct migration, the following usages are equivalent: | ||||||
|
|
||||||
| * `@exclude` and `@query(read: false, aggregate: false) @mutation(operations: []) @subscription(events: [])`. | ||||||
| * `@exclude(operations: [READ])` and `@query(read: false, aggregate: false)`. | ||||||
| * `@exclude(operation: [CREATE, UPDATE, DELETE])` and `@mutation(operations: [])`. | ||||||
|
|
||||||
| Whilst there is more verbosity, the directives are significantly more powerful and extensible as the library gains features. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| [full-text-migration] | ||||||
| === `@fulltext` changes | ||||||
|
|
||||||
|
|
@@ -854,6 +868,16 @@ type Record @limit(default: 10, max: 100) { | |||||
| } | ||||||
| ---- | ||||||
|
|
||||||
| === `@readonly` and `@writeonly` removed | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here about the label |
||||||
|
|
||||||
| The `@readonly` and `@writeonly` directives have been removed in favor of more granular configuration directives. | ||||||
| The new `@selectable` and `@settable` directives can be used to configure not only if fields are readable or writable, but also when they should be readable or writable. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| As a direct migration, the following usages are equivalent: | ||||||
|
|
||||||
| * `@readonly` and `@settable(onCreate: false, onUpdate: false)`. | ||||||
| * `@writeonly` and `@selectable(onRead: false, onAggregate: false)`. | ||||||
|
|
||||||
| [relationship-aggregate] | ||||||
| === `@relationship` changes | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use the label deprecated for it?