Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const server = new ApolloServer({
const { url } = await startStandaloneServer(server, {
listen: { port: 4000 },
context: async ({ req }) => ({
token: req.headers.Authorization,
token: req.headers.authorization,
}),
});
----
Expand Down
24 changes: 24 additions & 0 deletions modules/ROOT/pages/migration/v4-migration/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,20 @@ type query {

Additionally, escaping strings is no longer needed.

=== `@exclude` removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the label deprecated for it?

Suggested change
=== `@exclude` removed
=== `@exclude` label:[deprecated]


The `@exclude` directive has been removed in favor of much more granular configuration directives.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `@exclude` directive has been removed in favor of much more granular configuration directives.
The `@exclude` directive has been removed in favor of a more granular configuration directives.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

The new `@query`, `@mutation` and `@subscription` directives instead allow for fully granular configuration for each operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The new `@query`, `@mutation` and `@subscription` directives instead allow for fully granular configuration for each operation.
The `@query`, `@mutation` and `@subscription` directives instead allow for fully granular configuration for each operation.


As a direct migration, the following usages are equivalent:

* `@exclude` and `@query(read: false, aggregate: false) @mutation(operations: []) @subscription(events: [])`.
* `@exclude(operations: [READ])` and `@query(read: false, aggregate: false)`.
* `@exclude(operation: [CREATE, UPDATE, DELETE])` and `@mutation(operations: [])`.

Whilst there is more verbosity, the directives are significantly more powerful and extensible as the library gains features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Whilst there is more verbosity, the directives are significantly more powerful and extensible as the library gains features.
Despite the verbosity, the directives are significantly more powerful and extensible as the library gains features.


[full-text-migration]
=== `@fulltext` changes

Expand Down Expand Up @@ -854,6 +868,16 @@ type Record @limit(default: 10, max: 100) {
}
----

=== `@readonly` and `@writeonly` removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here about the label


The `@readonly` and `@writeonly` directives have been removed in favor of more granular configuration directives.
The new `@selectable` and `@settable` directives can be used to configure not only if fields are readable or writable, but also when they should be readable or writable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The new `@selectable` and `@settable` directives can be used to configure not only if fields are readable or writable, but also when they should be readable or writable.
The `@selectable` and `@settable` directives can be used to configure not only if fields are readable or writable, but also when they should be readable or writable.


As a direct migration, the following usages are equivalent:

* `@readonly` and `@settable(onCreate: false, onUpdate: false)`.
* `@writeonly` and `@selectable(onRead: false, onAggregate: false)`.

[relationship-aggregate]
=== `@relationship` changes

Expand Down