Tackling user feedback #35

lidiazuin · 2023-09-18T09:21:05Z

No description provided.

neo-technology-commit-status-publisher · 2023-09-19T10:06:37Z

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

darrellwarde

Some specific comments below, but I'm generally confused by this PR - the code examples in the table don't particularly match to the row, and I'm not 100% clear on what they are trying to demonstrate. Could you shed some light on the feedback at hand that led to this @lidiazuin?

modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc

modules/ROOT/pages/ogm/reference.adoc

…straints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com>

darrellwarde · 2023-09-22T15:21:41Z

@lidiazuin, I think merging these changes to the OGM reference will render the page quite inconsistent. If you go to the preview, you'll see that the table of argument for update now has three columns, but the other four operations still just have a two column table. We should probably be considering making it consistent across the board.

lidiazuin · 2023-09-25T09:48:08Z

@lidiazuin, I think merging these changes to the OGM reference will render the page quite inconsistent. If you go to the preview, you'll see that the table of argument for update now has three columns, but the other four operations still just have a two column table. We should probably be considering making it consistent across the board.

I agree. But then would you rather add examples to all cases or keep them the way they are?

darrellwarde · 2023-09-25T10:02:13Z

That's a lot of examples to add. 😅 In the long term, I would like to get rid of this API reference page entirely, and switch to more tutorial/how-to style. With that in mind, would it be worth the effort now?

lidiazuin · 2023-09-25T10:04:26Z

Not really, no. So I will revert that part!

darrellwarde

Looks good, just the one suggestion that needs updating!

modules/ROOT/pages/ogm/reference.adoc

Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com>

* Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com>

* Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Update publish.yml * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Update docs-teardown.yml * Update docs-pr.yml * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Fix scalar description placeholders #38 (#39) * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Fix scalar description placeholders (#38) --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * fixing conflicts; * fixing conflicts * fixing conflicts --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com>

* Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com>

* Editorial revie of Introspector and OGM pages * Update content-nav.adoc (neo4j#37) Fix location of driver configuration page * Editorial review of the latest additions (neo4j#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (neo4j#31) (neo4j#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (neo4j#31) (neo4j#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (neo4j#31) (neo4j#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (neo4j#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (neo4j#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com>

* Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Fix scalar description placeholders #38 (#39) * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Fix scalar description placeholders (#38) --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Editorial review of the most recent changes * reverting changes to partials * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * fixing conflict --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com>

* Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>

* Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> * Removing repeated mention (#76) --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>

* rebase (#75) * Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com> * rebase (#77) * Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> * Removing repeated mention (#76) --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>

Tackling user feedback

e71e8fc

lidiazuin added dev cherry-pick-to-4.x labels Sep 18, 2023

lidiazuin added 2 commits September 18, 2023 12:02

card 4800, adding example for arguments in update queries

7337bf2

updating cypher query for fulltext index creation

7e18339

lidiazuin marked this pull request as ready for review September 18, 2023 14:56

bumping to test surge

5ad7051

darrellwarde reviewed Sep 19, 2023

View reviewed changes

modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Outdated Show resolved Hide resolved

modules/ROOT/pages/ogm/reference.adoc Outdated Show resolved Hide resolved

lidiazuin and others added 3 commits September 21, 2023 10:36

revert

7645ba2

revert

f5b8eb7

Update modules/ROOT/pages/type-definitions/directives/indexes-and-con…

4070eab

…straints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com>

lidiazuin mentioned this pull request Sep 22, 2023

Editorial review of Introspector and OGM pages #36

Merged

lidiazuin added 2 commits September 25, 2023 12:06

reverting changes on the api reference page

6980a27

update

14425a6

darrellwarde approved these changes Sep 25, 2023

View reviewed changes

modules/ROOT/pages/ogm/reference.adoc Outdated Show resolved Hide resolved

Update modules/ROOT/pages/ogm/reference.adoc

41b2210

Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com>

lidiazuin merged commit 41e8a1c into neo4j:dev Sep 25, 2023

lidiazuin deleted the userfeedback branch September 25, 2023 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tackling user feedback #35

Tackling user feedback #35

Uh oh!

lidiazuin commented Sep 18, 2023

Uh oh!

neo-technology-commit-status-publisher commented Sep 19, 2023 •

edited

Loading

Uh oh!

darrellwarde left a comment

Uh oh!

Uh oh!

Uh oh!

darrellwarde commented Sep 22, 2023

Uh oh!

lidiazuin commented Sep 25, 2023

Uh oh!

darrellwarde commented Sep 25, 2023

Uh oh!

lidiazuin commented Sep 25, 2023

Uh oh!

darrellwarde left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Tackling user feedback #35

Tackling user feedback #35

Uh oh!

Conversation

lidiazuin commented Sep 18, 2023

Uh oh!

neo-technology-commit-status-publisher commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darrellwarde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

darrellwarde commented Sep 22, 2023

Uh oh!

lidiazuin commented Sep 25, 2023

Uh oh!

darrellwarde commented Sep 25, 2023

Uh oh!

lidiazuin commented Sep 25, 2023

Uh oh!

darrellwarde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

neo-technology-commit-status-publisher commented Sep 19, 2023 •

edited

Loading