Fixing examples and incorrect information #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
angrykoala
approved these changes
Dec 6, 2023
Co-authored-by: angrykoala <angrykoala@outlook.es>
lidiazuin
added a commit
that referenced
this pull request
Dec 6, 2023
* Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>
lidiazuin
added a commit
that referenced
this pull request
Dec 6, 2023
* Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> * Removing repeated mention (#76) --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>
lidiazuin
added a commit
that referenced
this pull request
Dec 6, 2023
* rebase (#75) * Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com> * rebase (#77) * Update docs-pr.yml Add dev branch * Update docs-teardown.yml Add dev branch * Update content-nav.adoc (#37) Fix location of driver configuration page * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Fix scalar description placeholders (#38) * Use aliases-redirects extension (#40) * Fixing typo in code example (#45) * Update to the migrations guide (#43) * Update to the migrations guide * fixing conflicts * Apply suggestions from code review Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * changes after review --------- Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> * Editorial review of Introspector and OGM pages (#36) * Editorial revie of Introspector and OGM pages * Update content-nav.adoc (#37) Fix location of driver configuration page * Editorial review of the latest additions (#34) * Update publish.yml * Editorial review of the most recent changes * reverting changes to partials * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * fixing note formatting * Add page-aliases for version 4 (#31) (#32) Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> * Editorial review of the most recent changes * Add page-aliases for version 4 (#31) * revert * Apply suggestions from code review Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * update * update * directives page modification * review of the api reference page * updates after review * removing = from notes, will open another pr to cover all examples in the docs * Apply suggestions from code review Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing note format with four = * fixing conflicts * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * Tackling user feedback (#35) * Tackling user feedback * card 4800, adding example for arguments in update queries * updating cypher query for fulltext index creation * bumping to test surge * revert * revert * Update modules/ROOT/pages/type-definitions/directives/indexes-and-constraints.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * reverting changes on the api reference page * update * Update modules/ROOT/pages/ogm/reference.adoc Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> * fixing tabbed example * changes after revirew * fix list --------- Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> * Editorial review of the custom resolvers page (#42) * Editorial review of the custom resolvers page * review of the driver configurtion page * Removing redundant link (#51) * Adding link to driver configuration in the getting started page (#50) * Adding link to driver configuration in the getting started page * replacing word * Fixing formatting of list of steps (#54) * Add documentation on CDC Engine for subscriptions * Editorial review of the new CDC content (#57) * Add how to add session and transaction to the execution context (#59) * docs: removes aggregate defaulting to false note (#61) * docs: remove link to nextjs integration (#63) * Update content-nav.adoc Removes the duplicate item "Introspector" from content nav * docs: change the requirement of connectOrCreate to require `@unique` (#66) * docs: change the requirement of connectOrCreate to require `@unique` * Fixing content nav for auth (#69) * docs: add section about passing in JWTs (#71) Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Add guide for `@relayId` (#73) * Add guide for `@relayId` * Apply suggestions from code review Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> --------- Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> * Fix typo * Fixing examples and incorrect information (#74) * Fixing examples and incorrect information * Update modules/ROOT/pages/queries-aggregations/filtering.adoc Co-authored-by: angrykoala <angrykoala@outlook.es> --------- Co-authored-by: angrykoala <angrykoala@outlook.es> * Removing repeated mention (#76) --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com> --------- Co-authored-by: Neil Dewhurst <ndewhurst@gmail.com> Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com> Co-authored-by: MacondoExpress <simone.gammicchia@gmail.com> Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com> Co-authored-by: angrykoala <angrykoala@outlook.es> Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.