-
Notifications
You must be signed in to change notification settings - Fork 83
Info about skipping consistency check for performance improvement on … #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
renetapopova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidiazuin, thanks for picking this up. Who told you that command and option? I can't find it anywhere.
|
|
||
| In case you want to skip the check, with the option to run it manually at some other time, run the neo4j-backup tool with the `-verify false` option: | ||
| ---- | ||
| ./bin/neo4j-backup -from single://127.0.0.1 -to /tmp/foo -verify false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find this command and the verify option in the command help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this from an old developer guide, but I thought of asking someone from engineering to take a look to see whether this is still valid or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. It says "Applicable versions 3.5 4.0 4.1 4.2 4.3 4.4" but also has "Retired:" in the title. I'll check the code. You can ask the Clustering team since they are the owners of the backup and restore if we have anything similar in 5.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, in 4.4, when I run ./neo4j-admin backup --help, I see that there is an option --check-consistency (true by default). So if you want to skip the consistency check, you can add --check-consistency false to the backup command and it'll skip it. This is described here: https://neo4j.com/docs/operations-manual/4.4/backup-restore/online-backup/#online-backup-resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks for checking it. In the 5.x version of this same page, there's nothing about the consistency check though. I have asked the Clustering team to review this PR, but I guess I can open another one for 4.x linking to this section that you suggested instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing about it on both 4.x and 5.x planning pages because the planning is about backing up in general (all possible ways). The consistency check is performed only on the backups that are created with the online back command. Therefore, the section about consistency checks is on the Back up an online database page. I don't think we need anything more than what we currently have. Perhaps, we can add a link to the consistency checker page - https://neo4j.com/docs/operations-manual/5/tools/neo4j-admin/consistency-checker/, in case they have skipped it during the backup and want to run it later. This is for version 4.4.
For 5.x, we need to ask the clustering if there is a way of skipping the consistency check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidiazuin @renetapopova the consistency checking functionality has been completely removed from the backup command in 5.x. I believe this is because it is not possible to perform a consistency check on a diff backup. So the only way not to perform the consistency check now is offline using tool as documented here https://neo4j.com/docs/operations-manual/5/tools/neo4j-admin/consistency-checker/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the correct process now is to either perform a consistency check periodically on your full backups or use the aggregate command to combine diff backups together with a full to create a complete full backup (all this can be done offline). The run the consistency check on the complete aggregated backup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tonbut . I believe with your information now this PR can be actually closed and we can work only in the 4.x one, in case it is still valid.
|
Looks like you've updated the documentation! Check out your changes at https://neo4j-docs-operations-930.surge.sh |
This PR is related to neo4j#930
This PR is related to neo4j#930
This PR is related to neo4j#930
This PR is related to neo4j#930
…backup