Skip to content

Conversation

@lidiazuin
Copy link
Contributor

@lidiazuin lidiazuin commented Jul 28, 2023

This PR is related to #930

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jul 28, 2023

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@lidiazuin lidiazuin requested a review from renetapopova July 28, 2023 14:37
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, let me know if you find my comments confusing and I am happy to jump on a call to show you what I mean.

If you are running Neo4j in the cloud, you may use a different availability zone or even a separate cloud provider.
Since backups are kept for a long time, the longevity of archival storage should be considered as part of backup planning.

[[performance-improvement]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this section. As I said, all these performance considerations are explained here https://neo4j.com/docs/operations-manual/4.4/backup-restore/online-backup/#online-backup-resources. The planning talks about the different options available. When they choose which one they want to use, they can read about its pros and cons on their specific page.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add a link to this page modules/ROOT/pages/tools/neo4j-admin/consistency-checker.adoc after this sentence or as part of it:
"Alternatively, you can decouple the backup operation from the consistency check (using the neo4j-admin backup option --check-consistency=false) and schedule that part of the workflow to happen at a later point in time, on a dedicated machine."

The `neo4j-admin` tool is located in the `bin` directory.
If checking the consistency of a database, note that it has to be stopped first or else the consistency check will result in an error.

This check is performed automatically.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true for this page. This page is about how to check the consistency of a database or a backup manually.

If checking the consistency of a database, note that it has to be stopped first or else the consistency check will result in an error.

This check is performed automatically.
In case you want to skip the check, with the option to run it manually at some other time, refer to the xref:backup-restore/online-backup.adoc#online-backup-resources[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is confusing. This page is about a manual check, they don't want to skip it. They've already skipped it when they were doing the backup. Now they want to run the check.

@lidiazuin lidiazuin requested a review from renetapopova July 31, 2023 10:47
@lidiazuin lidiazuin merged commit ab28497 into neo4j:4.4 Aug 10, 2023
@lidiazuin lidiazuin deleted the 4.4-skipconsistencychecker branch August 10, 2023 10:07
lidiazuin added a commit to lidiazuin/docs-operations that referenced this pull request Aug 10, 2023
lidiazuin added a commit to lidiazuin/docs-operations that referenced this pull request Aug 10, 2023
lidiazuin added a commit to lidiazuin/docs-operations that referenced this pull request Aug 10, 2023
@lidiazuin lidiazuin mentioned this pull request Aug 10, 2023
lidiazuin added a commit to lidiazuin/docs-operations that referenced this pull request Aug 10, 2023
lidiazuin added a commit that referenced this pull request Aug 10, 2023
lidiazuin added a commit that referenced this pull request Aug 10, 2023
Cherry-picked from #932
lidiazuin added a commit that referenced this pull request Aug 10, 2023
lidiazuin added a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants