-
Notifications
You must be signed in to change notification settings - Fork 83
Add info on skipping consistency check in 4.x #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
renetapopova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, let me know if you find my comments confusing and I am happy to jump on a call to show you what I mean.
| If you are running Neo4j in the cloud, you may use a different availability zone or even a separate cloud provider. | ||
| Since backups are kept for a long time, the longevity of archival storage should be considered as part of backup planning. | ||
|
|
||
| [[performance-improvement]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this section. As I said, all these performance considerations are explained here https://neo4j.com/docs/operations-manual/4.4/backup-restore/online-backup/#online-backup-resources. The planning talks about the different options available. When they choose which one they want to use, they can read about its pros and cons on their specific page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add a link to this page modules/ROOT/pages/tools/neo4j-admin/consistency-checker.adoc after this sentence or as part of it:
"Alternatively, you can decouple the backup operation from the consistency check (using the neo4j-admin backup option --check-consistency=false) and schedule that part of the workflow to happen at a later point in time, on a dedicated machine."
| The `neo4j-admin` tool is located in the `bin` directory. | ||
| If checking the consistency of a database, note that it has to be stopped first or else the consistency check will result in an error. | ||
|
|
||
| This check is performed automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true for this page. This page is about how to check the consistency of a database or a backup manually.
| If checking the consistency of a database, note that it has to be stopped first or else the consistency check will result in an error. | ||
|
|
||
| This check is performed automatically. | ||
| In case you want to skip the check, with the option to run it manually at some other time, refer to the xref:backup-restore/online-backup.adoc#online-backup-resources[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is confusing. This page is about a manual check, they don't want to skip it. They've already skipped it when they were doing the backup. Now they want to run the check.
This PR is related to neo4j#930
This PR is related to neo4j#930
This PR is related to neo4j#930
This PR is related to neo4j#930
This PR is related to #930