Server refuses connection due to Appache Compress being referenced on server (NoClassDefFoundError)

[SilverDavidMC]

Minecraft Version: 1.20.4

NeoForge Version: 20.4.70-beta

Logs:

• Client: https://gist.github.com/SilverDavidMC/ee83c0fb6a87621cb81f003d4d0ad892#file-client_log
• Server: https://gist.github.com/SilverDavidMC/ee83c0fb6a87621cb81f003d4d0ad892#file-server_log

Steps to Reproduce:

1. Set up and run a NeoForge 20.4.70-beta client and dedicated server without any mods installed on either.
2. Attempt to connect to the server.
3. Client is refused connection due to java.lang.NoClassDefFoundError: org/apache/commons/compress/utils/Lists.

Description of issue:

When connecting to a server, NeoForge references org/apache/commons/compress/utils/Lists in several networking classes, causing a NoClassDefFoundError because the Apache Compress library isn't available on dedicated servers. This bug only occurs in a live environment, not in userdev.

The following classes are affected:

NeoForge/src/main/java/net/neoforged/neoforge/network/negotiation/NetworkComponentNegotiator.java

Line 93 in bd3a222

final List<NegotiatedNetworkComponent> result = Lists.newArrayList();

NeoForge/src/main/java/net/neoforged/neoforge/common/extensions/IServerGamePacketListenerExtension.java

Line 44 in bd3a222

final List<Packet<? super ClientGamePacketListener>> packets = Lists.newArrayList();

NeoForge/src/main/java/net/neoforged/neoforge/network/registration/NetworkRegistry.java

Line 814 in bd3a222

return Lists.newArrayList(packets.iterator());

It's possible other classes are referencing the library, but this is all I could find for now. 20.4.69, before the networking rewrite, works as expected.

[Shadows-of-Fire]

Yeah we should avoid using those factory methods at all. They're just remnants from when the diamond operator sucked.