fix(ai): IssueIngestor resolves internal authors from registry (#12130) (#12144)

* fix(ai): IssueIngestor resolves internal authors from registry (#12130)

The community-multiplier hardcoded the operator login 'tobiu' as the
internal-author proxy, so in any fork / external / tenant deployment (no
'tobiu') every ticket read as community-authored and got the +0.5 boost,
inverting the discriminator the multiplier exists to apply.

Derive the internal-author set from the canonical identity registry
(ai/graph/identityRoots.mjs) as bare logins, mirroring the established
MemoryService.identityTrustTiers pattern. Add a static isCommunityAuthor()
seam whose size>0 guard degrades safely (multiplier off) for an empty
registry instead of boosting every ticket. The single hardcoded logic site
is removed; out-of-scope JSDoc @neo-* mentions are left to the
archaeology-cleanup epic.

Adds unit coverage: registry-derived bare-login set, internal-author not
boosted, external-author boosted, missing-author no-fire, and an empty-set
negative-mutation asserting the safe degrade.

Co-Authored-By: neo-opus-4-7 <neo-opus-4-7@neomjs.com>

* test(ai): drop transient ticket anchors from IssueIngestor spec (#12130)

Per PR #12144 review (@neo-gpt): remove the #12130 anchors from the community-multiplier test's comment block and describe title; behavior-only wording. No logic change.

Co-Authored-By: neo-opus-4-7 <neo-opus-4-7@neomjs.com>

---------

Co-authored-by: tobiu <tobiasuhlig78@gmail.com>

Author: neo-opus-ada

ai/services/ingestion/IssueIngestor.mjs

@@ -7,6 +7,7 @@ import Base from '../../../src/core/Base.mjs';
 import { Memory_StorageRouter as StorageRouter } from '../../services.mjs';
 import { Memory_GraphService as GraphService } from '../../services.mjs';
 import logger from '../../mcp/server/memory-core/logger.mjs';
+import {IDENTITIES} from '../../graph/identityRoots.mjs';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname  = path.dirname(__filename);
@@ -52,6 +53,32 @@ class IssueIngestor extends Base {
         singleton: true
     }
 
+    /**
+     * @summary Bare GitHub logins of registered internal authors (human owner + swarm maintainers),
+     * derived from the canonical identity registry. The `@` prefix is stripped to match GitHub
+     * issue-author logins. An empty set disables the community multiplier (safe degrade) instead of
+     * boosting every ticket.
+     * @member {Set<String>} internalAuthorLogins
+     * @static
+     */
+    static internalAuthorLogins = new Set(
+        IDENTITIES.map(identity => identity.properties?.githubLogin).filter(Boolean).map(login => login.replace(/^@/, ''))
+    )
+
+    /**
+     * @summary Whether a ticket author qualifies for the community-multiplier boost: true when the
+     * author exists, the internal-author registry is non-empty, and the author is not a registered
+     * maintainer. The non-empty guard makes an unconfigured deployment degrade safely (multiplier
+     * off) rather than treating every ticket as community-authored.
+     * @param {String} author Ticket GitHub author login (bare form).
+     * @param {Set<String>} [internalAuthorLogins=IssueIngestor.internalAuthorLogins] Injectable internal-author set (test seam).
+     * @returns {Boolean}
+     * @static
+     */
+    static isCommunityAuthor(author, internalAuthorLogins = IssueIngestor.internalAuthorLogins) {
+        return Boolean(author) && internalAuthorLogins.size > 0 && !internalAuthorLogins.has(author)
+    }
+
     /**
      * @summary Parses the local file system for markdown files and explicitly syncs their state
      * into the Native Graph database. Re-asserts edge weights for OPEN issues, heavily discounting
@@ -190,8 +217,8 @@ class IssueIngestor extends Base {
                             baseWeight = 0.05;
                             logger.debug(`[IssueIngestor] Discounting topological weight for ${issueId} because it is BLOCKED_BY an OPEN issue.`);
                         } else {
-                            // Community Multiplier: Boost if ticket is external and has been triaged
-                            if (meta.author && meta.author !== 'tobiu') {
+                            // Community Multiplier: boost externally-authored (non-maintainer) tickets that have been triaged.
+                            if (IssueIngestor.isCommunityAuthor(meta.author)) {
                                 if (Array.isArray(meta.labels) && meta.labels.length > 0) {
                                     baseWeight += 0.5;
                                 }

test/playwright/unit/ai/services/ingestion/IssueIngestor.spec.mjs

@@ -208,3 +208,54 @@ test.describe('Neo.ai.daemons.services.IssueIngestor', () => {
         });
     });
 });
+
+/**
+ * Community-multiplier internal-author resolution. Replaces the prior hardcoded
+ * `meta.author !== 'tobiu'` check with a set derived from the canonical identity registry
+ * (`ai/graph/identityRoots.mjs`). The empty-registry case must degrade safely (multiplier OFF),
+ * not invert into boosting every ticket.
+ */
+test.describe('Neo.ai.daemons.services.IssueIngestor — community-multiplier internal-author set', () => {
+    let IssueIngestorClass;
+
+    test.beforeAll(async () => {
+        // The default export is the singleton instance; the static set + decision live on its class.
+        IssueIngestorClass = (await import('../../../../../../ai/services/ingestion/IssueIngestor.mjs')).default.constructor;
+    });
+
+    test('internalAuthorLogins is derived from the identity registry as bare logins (no @, no nulls)', () => {
+        const logins = IssueIngestorClass.internalAuthorLogins;
+
+        expect(logins).toBeInstanceOf(Set);
+        expect(logins.size).toBeGreaterThan(0);
+        // Owner + a known agent maintainer, normalized to bare form (matches GitHub issue authors).
+        expect(logins.has('tobiu')).toBe(true);
+        expect(logins.has('neo-opus-4-7')).toBe(true);
+        // The leading-@ registry form and null/empty entries must NOT leak through.
+        expect(logins.has('@tobiu')).toBe(false);
+        expect(logins.has('')).toBe(false);
+        expect([...logins].every(Boolean)).toBe(true);
+    });
+
+    test('isCommunityAuthor: a registered maintainer is NOT a community author (no boost)', () => {
+        expect(IssueIngestorClass.isCommunityAuthor('tobiu')).toBe(false);
+        expect(IssueIngestorClass.isCommunityAuthor('neo-opus-4-7')).toBe(false);
+    });
+
+    test('isCommunityAuthor: an external author IS a community author (boost eligible)', () => {
+        expect(IssueIngestorClass.isCommunityAuthor('some-external-contributor')).toBe(true);
+    });
+
+    test('isCommunityAuthor: a missing author is never a community author', () => {
+        expect(IssueIngestorClass.isCommunityAuthor('')).toBe(false);
+        expect(IssueIngestorClass.isCommunityAuthor(undefined)).toBe(false);
+        expect(IssueIngestorClass.isCommunityAuthor(null)).toBe(false);
+    });
+
+    test('isCommunityAuthor: an empty internal-author registry disables the multiplier (safe degrade, not boost-all)', () => {
+        // Negative-mutation guard: with an empty set, even an "external" author must NOT be boosted —
+        // the `size > 0` clause is what prevents the inverted every-ticket-boosted failure mode.
+        expect(IssueIngestorClass.isCommunityAuthor('some-external-contributor', new Set())).toBe(false);
+        expect(IssueIngestorClass.isCommunityAuthor('tobiu', new Set())).toBe(false);
+    });
+});