Commit 0df82f0
* feat(graph): computed GP no-survivor focus-as-route fallback — never empty (#14609)
Behavior 1 of the GP-guard follow-up split (parent defect merged via PR #14596):
when the contradiction guard blocks EVERY computed candidate (the no-survivor
state — the operator-verified zero-route class), the section now surfaces the
live Current Release / Incident Focus items as the numbered '**issue-N**:'
recommendation instead of rendering zero routes. parseGoldenPath then routes the
incident/release work rather than leaving the agent with no route.
- renderComputedGoldenPathContradictionSection (reached only when routedTopNodes
is empty) renders the focus candidates as numbered routes; the blocked content
stays in the diagnostic filtered line, never routed. The 'does not boost focus
into routing' clause gains its documented no-survivor exception — focus becomes
the route ONLY when nothing else survives, never alongside a surviving candidate.
- Title-less focus candidates fall back to their reasons label.
Tests: 2 new routing unit cases + the GoldenPathSynthesizer integration assertion
updated to the never-empty behavior. 9/9 routing + 47/47 synthesizer specs green.
Remaining behaviors (separate commits): guard-filter ledger recording + the
release-window config leaf.
* feat(graph): release-window config leaf — GP focus tracks the current release, not a shipped one (#14609)
Behavior 3 of the GP-guard follow-up split: the 'current release focus' version was hardcoded
as v13.1 in issueFocusSections.mjs, so a SHIPPED release kept scoring as current focus (the
operator-verified release-gate-blind class). Now sourced from a declarative AiConfig leaf
(ADR-0019 sanctioned form), read at the use site.
- ai/config.template.mjs: currentReleaseVersion leaf (default 'v13.2', NEO_CURRENT_RELEASE) —
advanced by publish.mjs at release (follow-on half of this behavior).
- issueFocusSections.mjs: reads aiConfig.currentReleaseVersion at the use site (never a stale
module-load capture), builds the title matcher regex-escaped, emits the release as the focus
reason. No release-version literal remains (AC falsifier: grep 'v13.1|V13_1_PATTERN' -> zero).
- Tests made release-agnostic: fixtures read aiConfig.currentReleaseVersion so they never re-stale.
47/47 GoldenPathSynthesizer + 9/9 routing specs green. config.mjs is gitignored; only the
template leaf is committed.
Remaining behavior: guard-filter ledger recording (behavior 2).
* fix(graph): no-survivor fallback routes only ACTIONABLE focus, epic→diagnostic (#14609)
Cycle-2 RA-2 (@neo-gpt review on #15058). The behavior-1 never-empty fallback
rendered EVERY live Current Focus candidate as a numbered machine route — including
epic umbrellas and not-code-ready items, which an agent would then try to route at.
Now the fallback filters focus candidates through the SAME isActionableComputedRecom-
mendation authority the computed surface uses (not a divergent label list): only
actionable leaves render as numbered routes, bounded to the caller-supplied Golden
Path render limit (aiConfig.goldenPathTopNodeRenderLimit, read at the synthesizer
use site). Epic-only / no-actionable focus renders diagnostically (named, never a
numbered route) rather than lying that an umbrella is immediate work.
3 new exact cases: epic+actionable-leaf (leaf routes, epic doesn't), epic-only (zero
routes, diagnostic), noisy-set (bounded to render limit). 59 passed / 0 failed.
---------
Co-authored-by: tobiu <tobiasuhlig78@gmail.com>
1 parent c718c0c commit 0df82f0
6 files changed
Lines changed: 230 additions & 80 deletions
File tree
- ai
- services/graph
- test/playwright/unit/ai/services/graph
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
42 | 51 | | |
43 | 52 | | |
44 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1110 | 1110 | | |
1111 | 1111 | | |
1112 | 1112 | | |
| 1113 | + | |
1113 | 1114 | | |
1114 | 1115 | | |
1115 | 1116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | | - | |
167 | | - | |
168 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
169 | 175 | | |
170 | 176 | | |
171 | | - | |
| 177 | + | |
| 178 | + | |
172 | 179 | | |
173 | 180 | | |
174 | 181 | | |
175 | 182 | | |
176 | 183 | | |
177 | 184 | | |
178 | | - | |
179 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
180 | 188 | | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
186 | 192 | | |
187 | 193 | | |
188 | 194 | | |
189 | 195 | | |
190 | | - | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
191 | 209 | | |
192 | 210 | | |
193 | 211 | | |
194 | 212 | | |
195 | | - | |
196 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
197 | 242 | | |
198 | 243 | | |
199 | 244 | | |
| |||
203 | 248 | | |
204 | 249 | | |
205 | 250 | | |
206 | | - | |
| 251 | + | |
207 | 252 | | |
208 | | - | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
209 | 256 | | |
210 | 257 | | |
211 | 258 | | |
| |||
0 commit comments