fix(lifecycle): suppress reported deference mentions (#14436) (#14437)

* fix(lifecycle): suppress reported deference mentions (#14420)

* fix(lifecycle): scan all deference phrase occurrences (#14436)

Author: neo-gpt

ai/scripts/lifecycle/deferencePhraseMatch.mjs

@@ -47,6 +47,48 @@ function stripMarkdownCode(text) {
         .replace(/`[^`\n]*`/g, ' ');
 }
 
+/**
+ * @summary Replaces quoted prose spans that report a phrase instead of using it.
+ * @param {String} text Assistant final-turn text with code spans already removed.
+ * @returns {String}
+ */
+function stripQuotedMentions(text) {
+    return text
+        .replace(/"[^"\n]*"/g, ' ')
+        .replace(/(^|[^a-zA-Z0-9_])'[^'\n]*'(?=$|[^a-zA-Z0-9_])/g, '$1 ');
+}
+
+/**
+ * @summary Checks whether a local match is a reported phrase rather than deference.
+ * @param {String} text Searchable assistant final-turn text.
+ * @param {Number} startIndex Match start index.
+ * @returns {Boolean}
+ */
+function isReportedMentionContext(text, startIndex) {
+    const prefix = text.slice(Math.max(0, startIndex - 80), startIndex).toLowerCase();
+
+    return /\b(?:the|this|that)\s+(?:literal\s+)?(?:phrase|text|string|trigger|matched\s+text|wording)\s*$/.test(prefix) ||
+           /\b(?:quoted|reported|mention(?:ed|ing)?|document(?:ed|ing)?)\s*$/.test(prefix);
+}
+
+/**
+ * @summary Checks whether a local "your call" match cites a prior operator decision.
+ * @param {String} phrase Matched deference phrase.
+ * @param {String} text Searchable assistant final-turn text.
+ * @param {Number} startIndex Match start index.
+ * @returns {Boolean}
+ */
+function isAttributiveCitationContext(phrase, text, startIndex) {
+    if (phrase.toLowerCase() !== 'your call') {
+        return false;
+    }
+
+    const prefix = text.slice(Math.max(0, startIndex - 80), startIndex).toLowerCase();
+
+    return /\bper\s+$/.test(prefix) ||
+           /\bas\s+you\s+(?:said|directed|called)\W*$/.test(prefix);
+}
+
 /**
  * @summary Returns the first deference phrase found in text, using case-insensitive boundary match.
  * @param {String} text Assistant final-turn text.
@@ -58,13 +100,23 @@ export function matchDeferencePhrase(text = '', phrases = DEFERENCE_PHRASES) {
         return null;
     }
 
-    const searchableText = stripMarkdownCode(text);
+    const searchableText = stripQuotedMentions(stripMarkdownCode(text));
 
     return phrases.find(phrase => {
         const escaped = phrase.replace(/[.*+?^${}()|[\]\\]/g, '\\$&').replace(/\s+/g, '\\s+'),
-              matcher = new RegExp(`(^|[^a-z0-9_])${escaped}(?=$|[^a-z0-9_])`, 'i');
+              matcher = new RegExp(`(^|[^a-z0-9_])${escaped}(?=$|[^a-z0-9_])`, 'ig');
+        let match;
+
+        while ((match = matcher.exec(searchableText)) !== null) {
+            const startIndex = match.index + match[1].length;
+
+            if (!isReportedMentionContext(searchableText, startIndex) &&
+                !isAttributiveCitationContext(phrase, searchableText, startIndex)) {
+                return true;
+            }
+        }
 
-        return matcher.test(searchableText);
+        return false;
     }) || null;
 }
 

test/playwright/unit/hooks/deferencePhraseMatch.spec.mjs

@@ -47,6 +47,30 @@ test.describe('ai/scripts/lifecycle/deferencePhraseMatch', () => {
         expect(matchDeferencePhrase('```text\nYour steer on the next lane.\n```')).toBeNull();
     });
 
+    test('does not match quoted or reported phrase mentions', () => {
+        expect(matchDeferencePhrase('The "your call" firing was a demonstrable false positive.')).toBeNull();
+        expect(matchDeferencePhrase("The 'per your call' firing was a demonstrable false positive.")).toBeNull();
+        expect(matchDeferencePhrase('The phrase your call is mentioned in the #14420 corpus.')).toBeNull();
+        expect(matchDeferencePhrase("The phrase if you'd rather is part of the deference register.")).toBeNull();
+    });
+
+    test('does not match attributive citations of an operator decision', () => {
+        expect(matchDeferencePhrase('Clio owns it, per your call.')).toBeNull();
+        expect(matchDeferencePhrase('The ownership route stands as you directed: your call is the source.'))
+            .toBeNull();
+    });
+
+    test('still matches live deference uses of your call', () => {
+        expect(matchDeferencePhrase('Your call on the branch cut.')).toBe('your call');
+        expect(matchDeferencePhrase("It's your call whether I pick this up.")).toBe('your call');
+        expect(matchDeferencePhrase('Your call?')).toBe('your call');
+    });
+
+    test('still fires when a live use follows a carved mention of the same phrase', () => {
+        expect(matchDeferencePhrase('The phrase your call recurs. Your call on the merge?')).toBe('your call');
+        expect(matchDeferencePhrase('Clio owns it per your call, but honestly, your call?')).toBe('your call');
+    });
+
     test('operator-dialogue carve skips the phrase match', () => {
         expect(detectDeferencePhrase('Your call on the exact color.', {operatorInLoop: true})).toBeNull();
         expect(detectDeferencePhrase('Your call on the exact color.', {operatorInLoop: false})).toBe('your call');