Commit 60b7f2c
authored
query_summaries and query_raw_memories passed a chroma `include` that omitted
'distances', so the response carried no distance values. The Dual-Pass re-ranker
(StorageRouter) read an empty distances array -> vectorDist 0 -> semanticScore a
constant 1, silently degrading ranking to topology-only and reporting
distance:0 / relevanceScore:1 on every result.
Add 'distances' to the include in MemoryService.queryMemories and
SummaryService.querySummaries. Restores real vector distances end-to-end:
Pass-1 distances -> real semanticScore -> composite rank -> relevanceScore.
Regression: two substrate-free guards capture the include each service sends and
assert it contains 'distances' (the prior relevanceScore > 0 assertion could not
catch a constant 1). Split from #12450 (bug-b, the score-reporting half).
1 parent 006c71d commit 60b7f2c
3 files changed
Lines changed: 56 additions & 2 deletions
File tree
- ai/services/memory-core
- test/playwright/unit/ai/services/memory-core
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1102 | 1102 | | |
1103 | 1103 | | |
1104 | 1104 | | |
1105 | | - | |
| 1105 | + | |
| 1106 | + | |
1106 | 1107 | | |
1107 | 1108 | | |
1108 | 1109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
371 | 371 | | |
372 | 372 | | |
373 | 373 | | |
374 | | - | |
| 374 | + | |
| 375 | + | |
375 | 376 | | |
376 | 377 | | |
377 | 378 | | |
| |||
Lines changed: 52 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
151 | 203 | | |
152 | 204 | | |
153 | 205 | | |
| |||
0 commit comments