Skip to content

Harden logger workflow event logging to avoid shell parse errors - #270

Merged
yakky merged 3 commits into
masterfrom
copilot/fix-failing-github-actions-workflow-job-9747611031
Aug 24, 2026
Merged

Harden logger workflow event logging to avoid shell parse errors#270
yakky merged 3 commits into
masterfrom
copilot/fix-failing-github-actions-workflow-job-9747611031

Conversation

Copilot AI commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Description

The Event Logger workflow was failing while printing github.event due to unsafe shell interpolation of JSON content. This updates the logging step to pass the payload through an environment variable and print it with printf so event payloads with shell-significant characters no longer break execution.

  • Problem fixed

    • Replaced direct inline expansion in run with a shell-safe pattern in .github/workflows/logger.yml.
  • Change detail

    • Store payload in env:
      • EVENT_JSON: ${{ toJSON(github.event) }}
    • Print safely in bash:
      • printf '%s\n' "$EVENT_JSON"
  • Updated workflow snippet

    - name: Logging
      env:
        EVENT_JSON: ${{ toJSON(github.event) }}
      run: |
        printf '%s\n' "$EVENT_JSON"

References

N/A

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

Copilot AI and others added 2 commits August 24, 2026 15:01
Co-authored-by: yakky <714711+yakky@users.noreply.github.com>
Co-authored-by: yakky <714711+yakky@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix GitHub Actions workflow job 97476110311 by updating logger.yml Harden logger workflow event logging to avoid shell parse errors Aug 24, 2026
Copilot AI requested a review from yakky August 24, 2026 15:03
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.47%. Comparing base (791b857) to head (59ec701).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files           8        8           
  Lines         936      936           
  Branches       67       67           
=======================================
  Hits          903      903           
  Misses         19       19           
  Partials       14       14           
Flag Coverage Δ
unittests 96.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 97.97%. remained the same — copilot/fix-failing-github-actions-workflow-job-9747611031 into master

@yakky
yakky marked this pull request as ready for review August 24, 2026 15:07
@yakky
yakky merged commit cbd94ee into master Aug 24, 2026
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants