Skip to content

feat: add store impl - #24

Merged
quake merged 5 commits into
nervosnetwork:mainfrom
quake:quake/store
May 29, 2024
Merged

feat: add store impl#24
quake merged 5 commits into
nervosnetwork:mainfrom
quake:quake/store

Conversation

@quake

@quake quake commented May 22, 2024

Copy link
Copy Markdown
Member

No description provided.

@quake
quake requested review from chenyukang and contrun May 22, 2024 11:05
Comment thread src/ckb/network.rs
SupervisionEvent::ActorTerminated(who, _, _) => {
debug!("Actor {:?} terminated", who);
}
SupervisionEvent::ActorPanicked(who, _) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better fail fast to expose the panic issue early.

@contrun contrun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed a new update to testnet-ready branch to rename a few things. Can you rebase this PR? BTW, I think testnet-ready can be merged into main first. I have created a PR for that #33.

quake and others added 4 commits May 29, 2024 16:34
author quake <quake.wang@gmail.com> 1716354557 +0900
committer quake <quake.wang@gmail.com> 1716793125 +0900

feat: add store impl
@quake
quake changed the base branch from testnet-ready to main May 29, 2024 07:45
@quake
quake merged commit 7a615fa into nervosnetwork:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants