Fix Enter key omitting the selected serial line ending - #52
Open
CAOShurong wants to merge 1 commit into
Open
Conversation
CAOShurong
marked this pull request as ready for review
August 9, 2026 02:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46.
The issue report by @grbl-IO correctly identified that the Enter handler called
sendTextwith only the text, while the Send button also passedinput.endlineToSend. This makes both paths call the same function with the same two arguments, so devices requiring CR, LF, or CRLF receive the configured ending regardless of how the command is submitted.Validation: the tracked source now has two matching handlers (Enter and Send button) using
input.sendText(input.textToSend, input.endlineToSend). The repository does not define an automated test for this static Vue template.