Fix FloatBar DPI-aware content sizing - #245
Conversation
|
Thanks for the PR, I will review this. |
|
Thermo-nuclear code-quality review (automated; @Finesssee for merge gating) Verdict: Approve on code quality (minor nits). Block on process before merge — see the last section. The change is small, direct, and behaviorally correct. Switching Nits (non-blocking):
Process (required before merge per
|
|
Merged 🎉 Thank you @klken88 — clean fix. CUA-verified on a real desktop debug build (scale 1.0): the float bar renders at full size, sits at its content rect, and toggles cleanly (proof-245 artifacts: settings-menu.png, floatbar-window.png). Note for the record: the shipped math (CSS px × devicePixelRatio → PhysicalSize) is also covered by your jsdom test at 1.5 scale; a live 1.5-scale run needs a scaled monitor, but the 1.0 non-regression plus the unit test cover the change. Ships in the next release. |
Summary
Describe what changed and why.
Related issue
Fixes #
Affected areas
Check every area this PR changes or could affect:
Validation
Hosted PR check runs on Blacksmith Windows when
CI_BUDGET_MODEis notoff(see.github/workflows/pr-check.ymlandCONTEXT.md). Still run the local slice and list commands/results below. If a check is not relevant, say why.powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -All -Version <version>powershell.exe -File scripts\windows-release-build.ps1 -Ref <ref> -SmokeInstallUI / tray proof
For UI, tray, settings, or visual behavior changes, use CUA Driver for visual proof. If CUA Driver cannot be used, explain why and attach equivalent manual proof.
Notes for reviewers
Call out risky areas, follow-up work, or anything reviewers should focus on.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.