Add per-notification custom sounds (supersedes #249) - #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes
Summary
Per-notification-event custom WAV sounds: 7 embedded built-in sounds (48 kHz stereo PCM), per-event choose/preview/clear, Windows system-sound mapping preserved as default, serialized playback worker, toast audio silenced, save-time WAV validation (RIFF chunk walk), data-driven settings UI.
Review fixes on top of #249
sound_volumechain end-to-end (settings, bridge types, locale keys in all 7 catalogs, test mocks) — the field was never consumed by playback.as NotificationSoundThemecast with a typed guard.Validation
local-check.ps1exit 0 on the branch; 857 rust + 328 tauri + 215 frontend tests; clippy -D warnings both crates; check-locale 732 keys.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.