docs: clarify SignPath code signing is pending, not yet implemented - #270
Merged
Conversation
README claimed releases are SignPath-signed while the next line said they are unsigned; CODE_SIGNING.md described a pipeline signing step that does not exist. Mark SignPath signing as planned/pending onboarding, label the unimplemented pipeline step, and state current artifacts are unsigned and verified via published SHA-256 sidecars. Refs #257
Finesssee
commented
Aug 8, 2026
Finesssee
left a comment
Collaborator
Author
There was a problem hiding this comment.
Independent review (posted as comment because GitHub forbids APPROVE on one's own PR): verified (1) diff touches only README.md and docs/CODE_SIGNING.md; (2) both now accurately state SignPath signing is planned/pending onboarding and that current release artifacts are unsigned with SHA-256 sidecar verification; (3) explicitly states it does NOT resolve #257 — refs only, no closing keyword; (4) markdown only, no workflow/pipeline code; (5) head MERGEABLE/CLEAN, checks skipped per pr-check.yml docs paths-ignore, zero review threads. This fixes the self-contradictory README callout and corrects the pipeline signing step description in CODE_SIGNING.md. Proceeding to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs-only correction of the code-signing statements:
scripts/windows-release-build.ps1or anywhere in the repo. It now opens with a Status: pending onboarding — not yet implemented note stating all current artifacts are unsigned and authenticity relies on the published SHA-256.sha256sidecars, labels the pipeline signing step Not yet wired, and marks the Notes section as applying once signing is active.The signing policy, roles, and target process are kept future-ready; only the tense/placement of claims changed. No workflow code or secrets were added — no SignPath credentials exist yet.
Why
Refs #257 — during the Defender
Trojan:Win32/Wacatac.B!mlinvestigation, both v0.47.0 artifacts verified asNotSignedand no signing step exists in the pipeline, so the docs misstated reality in both directions (README also contradicted itself in adjacent lines).What this does NOT do
Checks
Docs-only change:
pr-check.ymlignoresdocs/**and**/*.mdonpull_request, so no CI jobs are expected to run for this PR.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.