Skip to content

docs: clarify SignPath code signing is pending, not yet implemented - #270

Merged
Finesssee merged 1 commit into
mainfrom
docs/clarify-pending-code-signing
Aug 8, 2026
Merged

docs: clarify SignPath code signing is pending, not yet implemented#270
Finesssee merged 1 commit into
mainfrom
docs/clarify-pending-code-signing

Conversation

@Finesssee

@Finesssee Finesssee commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

What

Docs-only correction of the code-signing statements:

  • README.md: the "Code signing" callout claimed Windows releases are signed for free by SignPath.io while the very next line said installers are currently unsigned. It now states signing is planned, pending onboarding — not yet wired into the release pipeline. The accurate "currently unsigned, verify the SHA-256 published alongside each release" line is unchanged.
  • docs/CODE_SIGNING.md: the Build-system section described a SignPath submission step ("Release signing is submitted to SignPath from this pipeline") that does not exist in scripts/windows-release-build.ps1 or anywhere in the repo. It now opens with a Status: pending onboarding — not yet implemented note stating all current artifacts are unsigned and authenticity relies on the published SHA-256 .sha256 sidecars, labels the pipeline signing step Not yet wired, and marks the Notes section as applying once signing is active.

The signing policy, roles, and target process are kept future-ready; only the tense/placement of claims changed. No workflow code or secrets were added — no SignPath credentials exist yet.

Why

Refs #257 — during the Defender Trojan:Win32/Wacatac.B!ml investigation, both v0.47.0 artifacts verified as NotSigned and no signing step exists in the pipeline, so the docs misstated reality in both directions (README also contradicted itself in adjacent lines).

What this does NOT do

Checks

Docs-only change: pr-check.yml ignores docs/** and **/*.md on pull_request, so no CI jobs are expected to run for this PR.


View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.

README claimed releases are SignPath-signed while the next line said they
are unsigned; CODE_SIGNING.md described a pipeline signing step that does
not exist. Mark SignPath signing as planned/pending onboarding, label the
unimplemented pipeline step, and state current artifacts are unsigned and
verified via published SHA-256 sidecars.

Refs #257

@Finesssee Finesssee left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review (posted as comment because GitHub forbids APPROVE on one's own PR): verified (1) diff touches only README.md and docs/CODE_SIGNING.md; (2) both now accurately state SignPath signing is planned/pending onboarding and that current release artifacts are unsigned with SHA-256 sidecar verification; (3) explicitly states it does NOT resolve #257 — refs only, no closing keyword; (4) markdown only, no workflow/pipeline code; (5) head MERGEABLE/CLEAN, checks skipped per pr-check.yml docs paths-ignore, zero review threads. This fixes the self-contradictory README callout and corrects the pipeline signing step description in CODE_SIGNING.md. Proceeding to merge.

@Finesssee
Finesssee merged commit ad26a18 into main Aug 8, 2026
2 checks passed
@Finesssee
Finesssee deleted the docs/clarify-pending-code-signing branch August 8, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant