This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Remove default arguments in private method that aren't used #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seddy
force-pushed
the
fix_compilation_warning
branch
from
a061e6c to
c6a7b79
Compare
Adzz
approved these changes
Jan 5, 2018
Contributor
|
Probably no need to bump the version with this sort of fix but its no biggie. |
samsondav
approved these changes
Jan 5, 2018
Contributor
Author
|
@samphilipd - so just publish this over the top of the previous version (0.5.12)? Given it's an internal library, that sounds reasonable |
Contributor
Author
|
I'm making the assumption no-one else is using this of course 😳 |
seddy
force-pushed
the
fix_compilation_warning
branch
from
c6a7b79 to
5961a4f
Compare
This was causing the following compilation warning, but is ultimately
fine because we always pass options into this function. If we create a
case in the future that doesn't, we can add this default back in then.
$ mix compile
Compiling 6 files (.ex)
warning: default arguments in find/3 are never used
lib/closex/http_client.ex:88
seddy
force-pushed
the
fix_compilation_warning
branch
from
5961a4f to
d2e1037
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the following compilation warning, but is ultimately
fine because we always pass options into this function. If we create a
case in the future that doesn't, we can add this default back in then.