This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Use elixir formatter to format codebase #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpbowden
suggested changes
Jan 18, 2018
Contributor
tpbowden
left a comment
tpbowden
left a comment
There was a problem hiding this comment.
Looks good, but if we're going to enforce it you should add a step to circle to fail if it's not formatted (--check-formatted)
Adzz
approved these changes
Jan 18, 2018
tpbowden
approved these changes
Jan 18, 2018
tpbowden
reviewed
Jan 18, 2018
| - run: mix local.rebar --force | ||
| - run: elixir --version | ||
| - run: mix deps.get | ||
| - run: mix format --check-formatted |
Contributor
There was a problem hiding this comment.
You need to change the image to be 1,6
tpbowden
reviewed
Jan 18, 2018
| elixirc_paths: elixirc_paths(Mix.env), | ||
| elixir: "~> 1.5", | ||
| elixirc_paths: elixirc_paths(Mix.env()), | ||
| elixir: "~> 1.6", |
Contributor
There was a problem hiding this comment.
does this prevent it from being installed with 1.5?
Contributor
Author
There was a problem hiding this comment.
I assume so. Bumped the version a revision but maybe I should go minor in case this is true?
Contributor
Author
There was a problem hiding this comment.
Yeah this feels like a minor bump at least. Gonna change that now.
sadir
force-pushed
the
format_codebase
branch
from
34f6f28 to
7962cb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduce a pre-commit hook to make sure the codebase is formatted before a commit.
Instructions for the pre-commit hook in the README.