This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Ready for release 1.1.0 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adzz
reviewed
Sep 18, 2018
| @callback get_opportunity(id, opts) :: result | ||
| @callback create_opportunity(map, opts) :: result | ||
| @callback update_opportunity(id, map, opts) :: result | ||
| @callback create_task(id, String.t(), map, opts) :: result |
Contributor
There was a problem hiding this comment.
ah, did you put @impl true on the implementation I cant remember
Adzz
approved these changes
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the behaviour correctly for the
create_tasktypespec and bumps version number to 1.1.0