This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Pass values through #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Adzz can I get a review on this please? Need to merge this and another PR on the umbrella to fix this buyer request bug. |
Adzz
reviewed
Nov 13, 2017
| @not_found_id "not_found" | ||
| def not_found_id, do: @not_found_id | ||
|
|
||
| @not_found_query "Jasdeep singh ptjasdeepsingh@gmail.com" |
Contributor
There was a problem hiding this comment.
is this a real email address?
Contributor
There was a problem hiding this comment.
I would maybe vote we dont use .gmail in case it is an actual email address, is that possible?
Contributor
Author
There was a problem hiding this comment.
It's a valid one but may also be a real one - hence what I was asking in my PR description about anonymisation. Could be a real guy, but if it isn't I'd rather not change it because it's all over our elixir projects at the moment.
Contributor
There was a problem hiding this comment.
Okay yea thats fair man no wrries
Adzz
reviewed
Nov 13, 2017
| "title" => "sr. vice president", | ||
| "updated_by" => "user_MvDoAZA889UMrgsZbnXmHkJSomSi7qk2Iwc4JnGHTbo" | ||
| } | ||
| assert ^result = contacts |
Adzz
approved these changes
Nov 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this functionality for the bug fix I'm working on in rested.
Not sure how you guys feel about having Jasdeep Singh be our missing search for leads? Is he a real customer? Should I anonymise it?
If you can think of a way to make my deep merge in create_lead nicer I'm all ears. Only need the contacts field merged in this way. #