Allow injectable middleware to be used on static asset paths when a global prefix is present

[tristan957]

Bug Report

Current behavior

When using a global prefix, static assets do not sit behind the global prefix. When applying injectable middlewares in the AppModule.configure function, the middlewares only apply to routes behind the global prefix.

Expected behavior

Be able to use injectable middleware to protect static asset paths when a global prefix is in use.

Use case: Protecting static content

[tristan957]

Right now I have to workaround using a functional middleware and calling app.use in index.ts

[kamilmysliwiec]

Could you please show your current implementation?

[tristan957]

@kamilmysliwiec I will leave a partial implementation here. I am currently too busy to leave an entire example.

// index.ts

bootstrap() {
  const app = new NestApplication<ExpressAdapter>();
  app.useGlobalPrefix("/api/v1");
  app.useStaticAssets("./assets", { path: "/assets");
  app.run(8080);
}

export default class AppModule implements NestModule {
  configure(consumer: MiddlewareConsumer) {
    consumer.apply(MyMiddleware).forRoutes({ path: "assets" });
}

This is most likely an Express issue more than anything

In this configuration, requests going to the static assets will never be interrupted my the middleware. Instead the middleware will only apply to "/api/v1/assets" instead of "/assets"

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.