fix(plugin): preserve inferred responses for enum error statuses - #4014
Merged
kamilmysliwiec merged 1 commit intoJul 17, 2026
Merged
Conversation
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4009
Problem
When
@ApiResponseuses an enum status such asHttpStatus.BAD_REQUEST, the Swagger plugin does not resolve the enum value and treats it as a success response.As a result, the automatically generated
200response is omitted.Fix
Pass the TypeScript
TypeCheckerto the status check and resolve enum members withgetConstantValue().This preserves the existing behavior for numeric statuses and ensures that:
Tests
Added regression coverage for:
HttpStatus.BAD_REQUESTwith an inferred200responseHttpStatus.CREATEDsuppressing the inferred200responseVerified with:
pnpm testpnpm run buildpnpm run lint