Avoid logging critical error on reconnect when not needed#1004
Merged
FrankBakkerNl merged 5 commits intonet-daemon:mainfrom Nov 17, 2023
Merged
Avoid logging critical error on reconnect when not needed#1004FrankBakkerNl merged 5 commits intonet-daemon:mainfrom
FrankBakkerNl merged 5 commits intonet-daemon:mainfrom
Conversation
helto4real
approved these changes
Nov 17, 2023
Collaborator
helto4real
left a comment
There was a problem hiding this comment.
Good job with the tests!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
=======================================
Coverage 77.94% 77.94%
=======================================
Files 177 177
Lines 3545 3545
Branches 443 443
=======================================
Hits 2763 2763
Misses 607 607
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Avoid logging false critical message when reconnecting to HA
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: