Skip to content

Avoid logging critical error on reconnect when not needed#1004

Merged
FrankBakkerNl merged 5 commits intonet-daemon:mainfrom
FrankBakkerNl:fix_incorrectlogging
Nov 17, 2023
Merged

Avoid logging critical error on reconnect when not needed#1004
FrankBakkerNl merged 5 commits intonet-daemon:mainfrom
FrankBakkerNl:fix_incorrectlogging

Conversation

@FrankBakkerNl
Copy link
Copy Markdown
Contributor

Proposed change

Avoid logging false critical message when reconnecting to HA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the tests!

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1856886) 77.94% compared to head (cf218e8) 77.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files         177      177           
  Lines        3545     3545           
  Branches      443      443           
=======================================
  Hits         2763     2763           
  Misses        607      607           
  Partials      175      175           
Flag Coverage Δ
unittests 77.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankBakkerNl FrankBakkerNl merged commit 99fabb8 into net-daemon:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants