Skip to content

Conversation

@mrlux
Copy link
Contributor

@mrlux mrlux commented Dec 23, 2020

…mically

Breaking change

Proposed change

I think adding a development/debug/demo in the main repo is a very nice addition.
Here I made a change to move this development/debug code to its own project so it does not "pollute" the main code base.
The only link is a reference from the Service project to the NetDaemon.DevelopmentApps.csproj.
I do need to load the Assemblies in from the bin folder because dotnet does not load the bin dll's if there is no code reference (using NetDaemon.DevelopmentApps ...) somewhere in the Service project with would beat the purpose of separating the apps.
If you agree the dev.md will still need to be updated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real merged commit 4125fc3 into net-daemon:dev Dec 23, 2020
@mrlux mrlux deleted the feature/move_developmentapps_to_seperate_project branch December 23, 2020 20:07
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
…ically (net-daemon#255)

Co-authored-by: Wim Meisman <wim.meisman@vente-exclusive.com>
Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants