Skip to content

Mqtt extension to create an update entities in HA #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 5, 2022
Merged

Mqtt extension to create an update entities in HA #658

merged 17 commits into from
Feb 5, 2022

Conversation

@eugeneniemand
Copy link
Member

@eugeneniemand eugeneniemand commented Feb 4, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

skotl and others added 4 commits February 3, 2022 23:41
@skotl
Initial commit of MQTT entity management framework. (#656)
a651058 
* Initial commit of MQTT entity management framework.
Addable extension method `AddMqttExtensions()`, rough entity creation through `EntityUpdater` (which is probably a poor name) that needs more strongly-typed.

* DI scope update from PR comment
@eugeneniemand
Added Update and Remove methods and resolved some of the comments for…
228e3fd 
… PR #656
@eugeneniemand
Changing names to be less generic
30f3184
@eugeneniemand
Moved to src/extensions, renamed folder and fixed warning
4fc6954
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022 •
edited
Loading

Codecov Report

Merging #658 (5265d62) into dev (7ae0652) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #658      +/-   ##
==========================================
+ Coverage   80.71%   80.75%   +0.03%     
==========================================
  Files         118      118              
  Lines        3039     3039              
  Branches      325      325              
==========================================
+ Hits         2453     2454       +1     
  Misses        452      452              
+ Partials      134      133       -1
Flag Coverage Δ
unittests 80.75% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sClient/Internal/Net/WebSocketTransportPipeline.cs 91.22% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae0652...5265d62. Read the comment docs.

helto4real and others added 5 commits February 4, 2022 15:31
@helto4real
Add support for nuget and default host (#660)
a1fd37f
@eugeneniemand
Added Discovery prefix
c95a4bb
@eugeneniemand
Merge branch 'mqtt_extensions' of github.com:net-daemon/netdaemon int…
211efdd 
…o mqtt_extensions
@skotl
MQTT connect and publish can throw exceptions as well as return error…
15a917d 
… codes, so handle each case in a consistent manner by throwing a new MqttConnection or MqttPublish exception.

Add try...catch to the test app so that we can see when exceptions are thrown in called methods.
@skotl
1. Add XML comments
72b109b 
2. Remove unused IConfiguration arg from MessageSender constructor
helto4real
helto4real requested changes Feb 5, 2022
View reviewed changes
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use ConfigureAwait(false) and not supress those. Also keep only the interfaces used by users public.

helto4real
helto4real approved these changes Feb 5, 2022
View reviewed changes
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @eugeneniemand and @skotl really looking forward trying this!

@helto4real helto4real merged commit 041cc01 into dev Feb 5, 2022
@helto4real helto4real deleted the mqtt_extensions branch February 5, 2022 11:15
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@eugeneniemand @skotl @helto4real
Mqtt extension to create an update entities in HA (net-daemon#658)
b8dd561 
* Initial commit of MQTT entity management framework. (net-daemon#656)

* Initial commit of MQTT entity management framework.
Addable extension method `AddMqttExtensions()`, rough entity creation through `EntityUpdater` (which is probably a poor name) that needs more strongly-typed.

* DI scope update from PR comment

* Added Update and Remove methods and resolved some of the comments for PR net-daemon#656

* Changing names to be less generic

* Moved to src/extensions, renamed folder and fixed warning

* Added example app and fixed IOptions for mqtt config

* Fix CI Build error

* Add support for nuget and default host (net-daemon#660)

* Added Discovery prefix

* MQTT connect and publish can throw exceptions as well as return error codes, so handle each case in a consistent manner by throwing a new MqttConnection or MqttPublish exception.
Add try...catch to the test app so that we can see when exceptions are thrown in called methods.

* 1. Add XML comments
2. Remove unused IConfiguration arg from MessageSender constructor

* Resolving PR comments

* Merged Skotl's code and fixed hard coded retain flag

* Removing throw and fixed warning. Added comment for Delay

* address PR comments

* Internalising...

Co-authored-by: Scott Leckie <scott.leckie@kwolo.com>
Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skotl skotl skotl left review comments

@helto4real helto4real helto4real approved these changes

+1 more reviewer

@BeeHiveJava BeeHiveJava BeeHiveJava left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eugeneniemand @codecov-commenter @skotl @BeeHiveJava @helto4real