Adds nuget support #660
Merged
Adds nuget support #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helto4real
added a commit
that referenced
this pull request
Feb 5, 2022
* Initial commit of MQTT entity management framework. (#656) * Initial commit of MQTT entity management framework. Addable extension method `AddMqttExtensions()`, rough entity creation through `EntityUpdater` (which is probably a poor name) that needs more strongly-typed. * DI scope update from PR comment * Added Update and Remove methods and resolved some of the comments for PR #656 * Changing names to be less generic * Moved to src/extensions, renamed folder and fixed warning * Added example app and fixed IOptions for mqtt config * Fix CI Build error * Add support for nuget and default host (#660) * Added Discovery prefix * MQTT connect and publish can throw exceptions as well as return error codes, so handle each case in a consistent manner by throwing a new MqttConnection or MqttPublish exception. Add try...catch to the test app so that we can see when exceptions are thrown in called methods. * 1. Add XML comments 2. Remove unused IConfiguration arg from MessageSender constructor * Resolving PR comments * Merged Skotl's code and fixed hard coded retain flag * Removing throw and fixed warning. Added comment for Delay * address PR comments * Internalising... Co-authored-by: Scott Leckie <scott.leckie@kwolo.com> Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
* Initial commit of MQTT entity management framework. (net-daemon#656) * Initial commit of MQTT entity management framework. Addable extension method `AddMqttExtensions()`, rough entity creation through `EntityUpdater` (which is probably a poor name) that needs more strongly-typed. * DI scope update from PR comment * Added Update and Remove methods and resolved some of the comments for PR net-daemon#656 * Changing names to be less generic * Moved to src/extensions, renamed folder and fixed warning * Added example app and fixed IOptions for mqtt config * Fix CI Build error * Add support for nuget and default host (net-daemon#660) * Added Discovery prefix * MQTT connect and publish can throw exceptions as well as return error codes, so handle each case in a consistent manner by throwing a new MqttConnection or MqttPublish exception. Add try...catch to the test app so that we can see when exceptions are thrown in called methods. * 1. Add XML comments 2. Remove unused IConfiguration arg from MessageSender constructor * Resolving PR comments * Merged Skotl's code and fixed hard coded retain flag * Removing throw and fixed warning. Added comment for Delay * address PR comments * Internalising... Co-authored-by: Scott Leckie <scott.leckie@kwolo.com> Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: