Skip to content

Conversation

@PartemImperium
Copy link
Contributor

@PartemImperium PartemImperium commented Jun 26, 2022

Breaking change

Proposed change

Add an extension method on IServiceCollection that adds the 2 dependancies currently baked into UseNetDaemonAppSettings. This new method can be called from the existing HostbuilderExtensions.UseNetDaemonAppSettings to maintain backwards compatibility while allowing a single spot to add dependancies needed for the app. Therefore if someone chooses to manually set up the config providers they do not need to keep up on adding dependancies when changes are made in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@PartemImperium
Copy link
Contributor Author

I still have documentation to do. I plan on adding a page after this custom logging page (https://netdaemon.xyz/docs/v3/app_model/app_model_custom_logging) describing how you can use whatever config providers you want.

@codecov-commenter
Copy link

Codecov Report

Merging #724 (a4ee754) into dev (48613a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #724   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files         137      137           
  Lines        3508     3508           
  Branches      357      357           
=======================================
  Hits         2806     2806           
  Misses        557      557           
  Partials      145      145           
Flag Coverage Δ
unittests 79.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48613a2...a4ee754. Read the comment docs.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a small change but gives even more flexibility. Thanks!

@helto4real helto4real merged commit 7fc5698 into net-daemon:dev Jun 27, 2022
@PartemImperium PartemImperium deleted the feature/UseNetDaemonAppSettings-pull-configureServices branch June 28, 2022 03:10
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants