Fix #815, TaskCanceledException when calling service from Dispose(Async) #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ispose(Async) by avoiding Result-Handling task from being cancelled
helto4real
approved these changes
Dec 22, 2022
| .FirstAsync().ToTask(cancelToken); | ||
| .FirstAsync().ToTask(CancellationToken.None); | ||
| // We dont want to pass the incoming CancellationToken here because it will throw a TaskCanceledException | ||
| // when calling services from an Apps Dispose(Async) and hide possible actual exceptions |
Collaborator
There was a problem hiding this comment.
Calling services from Dispose feels kind of a anti-pattern. Dispose should only be used as clean up. Now potentially (but not likely) a call could block an App from stopping. Not sure about this one. What is the use case to use services in Dispose?
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
…ispose(Async) by avoiding Result-Handling task from being cancelled (net-daemon#816)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by avoiding Result-Handling task from being cancelled
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: