Skip to content

Fix #815, TaskCanceledException when calling service from Dispose(Async) #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Fix #815, TaskCanceledException when calling service from Dispose(Async) #816

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
238dee1
Fix #815, TaskCanceledException when calling service from Dispose(Asy…
FrankBakkerNl Dec 19, 2022
ca24505
Merge branch 'dev' into fix_815_CallSercvieFromDispose
FrankBakkerNl Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ private async Task<Task<HassMessage>> SendCommandAsyncInternal<T>(T command, Can
// this task will be returned and handled by caller
var resultEvent = _hassMessageSubject
.Where(n => n.Type == "result" && n.Id == command.Id)
.FirstAsync().ToTask(cancelToken);
.FirstAsync().ToTask(CancellationToken.None);
// We dont want to pass the incoming CancellationToken here because it will throw a TaskCanceledException
// when calling services from an Apps Dispose(Async) and hide possible actual exceptions
Copy link
Collaborator

@helto4real helto4real Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling services from Dispose feels kind of a anti-pattern. Dispose should only be used as clean up. Now potentially (but not likely) a call could block an App from stopping. Not sure about this one. What is the use case to use services in Dispose?


await _transportPipeline.SendMessageAsync(command, cancelToken);

Expand Down