Skip to content

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

This is the first PR of several that will add support to create, delete and list Helpers from HA.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real changed the title Input helper support on Client Input helper support in Client Jan 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Base: 80.85% // Head: 80.85% // No change to project coverage 👍

Coverage data is based on head (bd47e36) compared to base (172aa61).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head bd47e36 differs from pull request most recent head 5dc49a8. Consider uploading reports for the commit 5dc49a8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #831   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         159      159           
  Lines        4096     4096           
  Branches      405      405           
=======================================
  Hits         3312     3312           
  Misses        621      621           
  Partials      163      163           
Flag Coverage Δ
unittests 80.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nsions/HomeAssistantConnectionHelpersExtensions.cs 100.00% <ø> (ø)
...istant/Commands/CreateInputBooleanHelperCommand.cs 100.00% <ø> (ø)
...t/Common/HomeAssistant/Model/InputBooleanHelper.cs 66.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@helto4real helto4real marked this pull request as ready for review January 29, 2023 15:52
@helto4real helto4real enabled auto-merge (squash) January 31, 2023 17:21
@helto4real helto4real merged commit e30122f into dev Jan 31, 2023
@helto4real helto4real deleted the helpers_support branch January 31, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants