Skip to content

Input helper support in Client #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Input helper support in Client #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1404844
Support create input helper on IHomeAssistantConnection
helto4real Jan 29, 2023
a937d8b
Remove the Model folder
helto4real Jan 29, 2023
bd47e36
Fix public to internal for commands
helto4real Jan 31, 2023
5dc49a8
Fix required keyword
helto4real Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...rnal/HomeAssistantConnectionExtensions.cs → ...meAssistantConnectionHelpersExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using NetDaemon.Runtime.Internal.Model;
namespace NetDaemon.Client.HomeAssistant.Extensions;

namespace NetDaemon.Runtime.Internal;

internal static class HomeAssistantConnectionExtensions
public static class HomeAssistantConnectionHelpersExtensions
{
public static async Task<InputBooleanHelper?> CreateInputBooleanHelperAsync(
this IHomeAssistantConnection connection,
Expand Down
8 changes: 4 additions & 4 deletions ...emon.Runtime/Internal/Model/HassHelper.cs → ...HomeAssistant/Model/InputBooleanHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
using System.Text.Json.Serialization;

namespace NetDaemon.Runtime.Internal.Model;
namespace NetDaemon.Client.HomeAssistant.Model;

internal record InputBooleanHelper
public record InputBooleanHelper
{
[JsonPropertyName("name")] public string Name { get; init; } = string.Empty;
[JsonPropertyName("name")] public string Name { get; init; } = String.Empty;
[JsonPropertyName("icon")] public string? Icon { get; init; }
[JsonPropertyName("id")] public string Id { get; init; } = string.Empty;
[JsonPropertyName("id")] public string Id { get; init; } = String.Empty;
}
6 changes: 3 additions & 3 deletions .../Model/CreateInputBooleanHelperCommand.cs → ...mmands/CreateInputBooleanHelperCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Text.Json.Serialization;
using NetDaemon.Client.HomeAssistant.Model;

namespace NetDaemon.Runtime.Internal.Model;
namespace NetDaemon.Client.Internal.HomeAssistant.Commands;

internal record CreateInputBooleanHelperCommand : CommandMessage
{
Expand All @@ -10,7 +10,7 @@ public CreateInputBooleanHelperCommand()
Type = "input_boolean/create";
}

[JsonPropertyName("name")] public string Name { get; init; } = string.Empty;
[JsonPropertyName("name")] public required string Name { get; init; }
}

internal record DeleteInputBooleanHelperCommand : CommandMessage
Expand All @@ -20,7 +20,7 @@ public DeleteInputBooleanHelperCommand()
Type = "input_boolean/delete";
}

[JsonPropertyName("input_boolean_id")] public string InputBooleanId { get; init; } = string.Empty;
[JsonPropertyName("input_boolean_id")] public required string InputBooleanId { get; init; } = string.Empty;
}

internal record ListInputBooleanHelperCommand : CommandMessage
Expand Down
3 changes: 1 addition & 2 deletions src/Runtime/NetDaemon.Runtime.Tests/Internal/AppStateManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using NetDaemon.Client.Internal.Exceptions;
using NetDaemon.HassModel;
using NetDaemon.Runtime.Internal;
using NetDaemon.Runtime.Internal.Model;

namespace NetDaemon.Runtime.Tests.Internal;

Expand Down Expand Up @@ -109,7 +108,7 @@ public async Task TestGetStateAsyncNotExistReturnsCorrectStateEnabled()
n.SendCommandAndReturnResponseAsync<CreateInputBooleanHelperCommand, InputBooleanHelper>(
It.IsAny<CreateInputBooleanHelperCommand>(), It.IsAny<CancellationToken>()));
haConnectionMock.Verify(n =>
n.SendCommandAsync<CallServiceCommand>(It.IsAny<CallServiceCommand>(),
n.SendCommandAsync(It.IsAny<CallServiceCommand>(),
It.IsAny<CancellationToken>()));
}

Expand Down
1 change: 0 additions & 1 deletion src/Runtime/NetDaemon.Runtime.Tests/Internal/AppStateRepositoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using Microsoft.Extensions.Hosting;
using NetDaemon.Client.Internal.Exceptions;
using NetDaemon.Runtime.Internal;
using NetDaemon.Runtime.Internal.Model;

namespace NetDaemon.Runtime.Tests.Internal;

Expand Down