Skip to content

Handle and log exceptions during initialization after (re)connect to Home Assistant#992

Merged
helto4real merged 1 commit intonet-daemon:mainfrom
FrankBakkerNl:fix_startupExceptionHandling
Nov 7, 2023
Merged

Handle and log exceptions during initialization after (re)connect to Home Assistant#992
helto4real merged 1 commit intonet-daemon:mainfrom
FrankBakkerNl:fix_startupExceptionHandling

Conversation

@FrankBakkerNl
Copy link
Copy Markdown
Contributor

@FrankBakkerNl FrankBakkerNl commented Nov 6, 2023

Proposed change

Handle and log exceptions during initialization after (re)connect to Home Assistant.
Specifically you will now get a specific 'Unauthorized' message in case you are using a non-admin token.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dae2bca) 77.74% compared to head (6512d64) 77.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   77.74%   77.81%   +0.06%     
==========================================
  Files         177      177              
  Lines        3537     3539       +2     
  Branches      443      444       +1     
==========================================
+ Hits         2750     2754       +4     
+ Misses        611      608       -3     
- Partials      176      177       +1     
Flag Coverage Δ
unittests 77.81% <77.27%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ime/NetDaemon.Runtime/Internal/NetDaemonRuntime.cs 73.62% <77.27%> (+5.08%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real merged commit 9691a5d into net-daemon:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants