Skip to content

PLG: UNFIMP set ip to null to prevent changes if not returned #1727 - #1729

Merged
jokob-sk merged 1 commit into
mainfrom
next_release
Aug 4, 2026
Merged

PLG: UNFIMP set ip to null to prevent changes if not returned #1727#1729
jokob-sk merged 1 commit into
mainfrom
next_release

Conversation

@jokob-sk

@jokob-sk jokob-sk commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of missing or invalid IP address values by returning a null result instead of an invalid placeholder address.

@jokob-sk
jokob-sk merged commit 4e6110a into main Aug 4, 2026
6 of 7 checks passed
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c0c4d167-2e1a-414f-b59b-a1b4b99821d6

📥 Commits

Reviewing files that changed from the base of the PR and between 327e8f8 and f3e7545.

📒 Files selected for processing (1)
  • front/plugins/unifi_import/script.py

📝 Walkthrough

Walkthrough

The UniFi import script changes get_ip to return 'null' when it finds no valid IP value.

Changes

UniFi import IP handling

Layer / File(s) Summary
Update get_ip fallback
front/plugins/unifi_import/script.py
get_ip now returns 'null' instead of '0.0.0.0' when no valid IP value is found.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch next_release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant